From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11882 invoked by alias); 20 Dec 2002 19:52:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11840 invoked from network); 20 Dec 2002 19:51:58 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 209.249.29.67 with SMTP; 20 Dec 2002 19:51:58 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id gBKJotc19514; Fri, 20 Dec 2002 11:50:55 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Jim Blandy Cc: Fernando Nasser , gdb-patches@sources.redhat.com Subject: Re: [Jim Blandy ] RFA: Check that `Local' is not in scope when it shouldn't be References: From: David Carlton Date: Fri, 20 Dec 2002 12:01:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-12/txt/msg00596.txt.bz2 On 20 Dec 2002 13:36:40 -0500, Jim Blandy said: > Ping on this test suite patch. I'm confused: don't you want to do the first 'ptype Local' _before_ going up from foobar? In which case your added test might as well happen after you go up from foobar but before running to marker2. Also, we're actually kfailing things now, though we weren't when you first submitted the patch. So if you could modify the patch to actually call setup_kfail (which takes two arguments, the second one of which is presumably "*-*-*"), I'd appreciate it. What I would recommend is to replace this # setup_kfail "gdb/825" gdb_test "ptype Local" "No symbol \"Local\" in current context.*" \ "Local out of scope (gdb/825)" with something like gdb_send "ptype Local\n" gdb_expect { -re "No symbol \"Local\" in current context.*" { setup_kfail "gdb/825" "*-*-*" pass "Local out of scope" } -re "(actual output)" { setup_kfail "gdb/825" "*-*-*" fail "Local out of scope" -re ".*$gdb_prompt $" { fail "Local out of scope } timeout { fail "(timeout) Local out of scope" } For "actual output", you could either have one block for each of the outputs (pass or (k)fail) listed in the earlier "ptype Local" test, or you can just have one test that unifies each of the earlier outputs; whichever you think is easiest. This assumes that you think that GDB never gets this right currently; if you think that GDB sometimes does get it right, then don't put the setup_kfail before the pass message. Other than that, it looks good; I certainly like the basic idea. Also, for what it's worth, I personally prefer diff -up to diff -c. David Carlton carlton@math.stanford.edu