Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: RFC: Demangle partial symbols and save memory too
Date: Mon, 27 Jan 2003 22:09:00 -0000	[thread overview]
Message-ID: <ro17kcqqm6o.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <3E35A2EA.1080906@redhat.com>

On Mon, 27 Jan 2003 16:21:46 -0500, Andrew Cagney <ac131313@redhat.com> said:

> The more `char *' -> `const char *' stomping, the better.

I spent some time on my branch trying to make this change quite
broadly (basically, turning name members of various structs into const
char *'s and dealing with the fallout).  It ran into some serious
problems, though; I seem to recall that, ultimately, they came down to
decode_line_1 taking a char ** instead of a const char **.  And
decode_line_1 really does (temporarily) change the characters that are
pointed to, unfortunately.  So if we ever want to get this right
across the board, fixing decode_line_1 is probably the main
outstanding task.

I also toyed with trying to replace 'struct XXX *' with 'const struct
XXX *' wherever appropriate.  That one's harder, though, because there
are structures in GDB where values are computed lazily and cached: so
not only are there functions that are logically const but not actually
const, but I also worried that making too many declarations const now
would inhibit such caching in the future.  Maybe in a couple of years
we can switch GDB over to C++ instead of C and use 'mutable'...

David Carlton
carlton@math.stanford.edu


  reply	other threads:[~2003-01-27 22:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-26 22:27 Daniel Jacobowitz
2003-01-27  1:54 ` Paul N. Hilfinger
2003-01-27  2:02   ` Daniel Jacobowitz
2003-01-27 18:53 ` David Carlton
2003-01-27 19:00   ` Daniel Jacobowitz
2003-01-27 19:10     ` David Carlton
2003-01-27 21:21     ` Andrew Cagney
2003-01-27 22:09       ` David Carlton [this message]
2003-01-27 22:17         ` Andreas Schwab
2003-01-27 22:24           ` David Carlton
2003-01-27 23:17             ` Andrew Cagney
2003-01-28 23:57 ` Jim Blandy
2003-01-30  1:16   ` Daniel Jacobowitz
2003-02-04 18:07     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro17kcqqm6o.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox