From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2923 invoked by alias); 31 Mar 2003 22:53:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2916 invoked from network); 31 Mar 2003 22:53:33 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 31 Mar 2003 22:53:33 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h2VMrMR24168; Mon, 31 Mar 2003 14:53:22 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Adam Fedor Cc: GDB Patches , Daniel Jacobowitz , Andrew Cagney Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5] References: <3E16093D.3070907@doc.com> <3E7A3226.9040904@redhat.com> <20030320213945.GA17345@nevyn.them.org> <3E7A3D14.1020100@redhat.com> <20030320221924.GA25955@nevyn.them.org> <3E87A68C.6090301@doc.com> From: David Carlton Date: Mon, 31 Mar 2003 22:53:00 -0000 In-Reply-To: <3E87A68C.6090301@doc.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-03/txt/msg00619.txt.bz2 On Sun, 30 Mar 2003 19:23:08 -0700, Adam Fedor said: > Here's my crack at doing [language-specific demangling]. This patch bothers me: it doesn't handle Java cleanly, and I'm not sure about the 'options' argument to language_demangle. It seems to me that, at the very least, there should be a java_demangle function defined that takes the options passed in, applies '| DMGL_JAVA' to it, and calls cplus_demangle. But I also wanted to double-check: does 'options' really make sense for all language types? If I'm reading the patch correctly, it looks like Objective C just throws it away. If that's the case, then I don't think that 'options' should be part of the language vector: if C++ needs it for internal purposes, then C++ could have its own more flexible demangler with that option (which Java could also use), but the version in the language vector should be more restricted. David Carlton carlton@math.stanford.edu