From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6993 invoked by alias); 3 Mar 2003 20:04:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6984 invoked from network); 3 Mar 2003 20:04:20 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by 172.16.49.205 with SMTP; 3 Mar 2003 20:04:20 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h23K4Jw10865; Mon, 3 Mar 2003 12:04:19 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: gdb-patches@sources.redhat.com Cc: Elena Zannoni , Jim Blandy Subject: Re: [patch] add linkage_name argument to lookup_partial_symbol References: From: David Carlton Date: Mon, 03 Mar 2003 20:04:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-03/txt/msg00064.txt.bz2 On 03 Mar 2003 11:50:54 -0800, David Carlton said: > Currently, lookup_partial_symbol only matches on natural names, not on > linkage names. This can be a problem when it's called from > lookup_symbol_aux_psymtabs: that functions cares about the linkage > name of the symbol in addition to its natural name. So the wrong > partial symtab could be found, leading to a "name found in psymtab but > not in symtab" error. I should also add another observation: after this patch goes in, every use of SYMBOL_MATCHES_NATURAL_NAME in symtab.c will be paired with a check on linkage names. This suggests that perhaps we should replace SYMBOL_MATCHES_NATURAL_NAME by a macro SYMBOL_MATCHES_NAMES that accepts a symbol, a linkage name (which might be NULL), and a natural name. On the other hand, we still have the uses of DEPRECATED_SYMBOL_MATCHES_NAME in minsyms.c, and there such a SYMBOL_MATCHES_NAMES wouldn't be appropriate (though the current SYMBOL_MATCHES_NATURAL_NAME might be). So it's not something to do right now, but it probably is something to keep in mind once minsyms.c has gotten cleaned up a bit, when we'll have a better idea where this macro might be used. (We should probably audit all uses of strcmp_iw within GDB when doing this.) David Carlton carlton@math.stanford.edu