Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Fernando Nasser <fnasser@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite] more selftest.exp tweaking
Date: Wed, 15 Jan 2003 17:34:00 -0000	[thread overview]
Message-ID: <ro11y3e8ggx.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <3E256E87.4010904@redhat.com>

On Wed, 15 Jan 2003 09:21:59 -0500, Fernando Nasser <fnasser@redhat.com> said:

> David, it is approved but please change the comment to state which
> compiler version you've seem this order.

Thanks, will do.

> P.S.: What I am hoping is that one day in the future we can get rid
> of some cases for very old compilers.  The comments will make it
> easier.  This is not a serious enough condition for adding an 'if'
> on the compiler version, me thinks...

No.  Unfortunately, I think that this particular problem will get
worse with future compilers, not better: instruction reordering by
compilers will only increase as optimizers get trickier.

Committed; patch is below.

David Carlton
carlton@math.stanford.edu

2003-01-15  David Carlton  <carlton@math.stanford.edu>

	* gdb.base/selftest.exp (do_steps_and_nexts): Allow gdb_sysroot.

Index: selftest.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v
retrieving revision 1.6
diff -u -p -r1.6 selftest.exp
--- selftest.exp	23 Dec 2002 16:56:25 -0000	1.6
+++ selftest.exp	15 Jan 2003 17:32:33 -0000
@@ -170,6 +170,12 @@ proc do_steps_and_nexts {} {
 		set description "step over current_directory initialization"
 		set command "step"
 	    }
+	    -re ".*gdb_sysroot = .*$gdb_prompt $" {
+		# NOTE: carlton/2003-01-15: More optimization reordering,
+		# observed on GCC 3.1.
+		set description "step over gdb_sysroot initialization"
+		set command "step"
+	    }
 	    -re "\[ \t\]+\{\r\n$gdb_prompt $" {
 		setup_xfail "mips-*-irix5*"
 		fail "$description ended up at odd location"


      reply	other threads:[~2003-01-15 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-14 20:29 David Carlton
2003-01-15 14:22 ` Fernando Nasser
2003-01-15 17:34   ` David Carlton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro11y3e8ggx.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox