From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31630 invoked by alias); 9 Apr 2003 17:23:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31615 invoked from network); 9 Apr 2003 17:23:32 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 9 Apr 2003 17:23:32 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h39HNFt01632; Wed, 9 Apr 2003 10:23:15 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/TESTSUITE] completion.exp References: <16019.23357.144916.774165@localhost.redhat.com> From: David Carlton Date: Wed, 09 Apr 2003 17:23:00 -0000 In-Reply-To: <16019.23357.144916.774165@localhost.redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-04/txt/msg00164.txt.bz2 On Tue, 8 Apr 2003 19:29:01 -0400, Elena Zannoni said: > +# If the directory name contains a '+' we must escape it, adding a backslash. > +# If not, the test below will fail because it will interpret the '+' as a > +# regext operator. > +regsub -all \\+ ${fullsrcdir} \\\+ dirstring Would it be better to use string_to_regexp instead of regsub? (But leaving in the comment as an indication of why you're using it.) David Carlton carlton@math.stanford.edu