From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YMjQARXzT2jjiBAAWB0awg (envelope-from ) for ; Mon, 16 Jun 2025 06:33:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ef8EVVbQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0338A1E102; Mon, 16 Jun 2025 06:33:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4C5231E089 for ; Mon, 16 Jun 2025 06:33:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA3DD3AE2632 for ; Mon, 16 Jun 2025 10:33:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA3DD3AE2632 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ef8EVVbQ Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20630.outbound.protection.outlook.com [IPv6:2a01:111:f403:2009::630]) by sourceware.org (Postfix) with ESMTPS id 1004F383AD56 for ; Mon, 16 Jun 2025 10:33:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1004F383AD56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1004F383AD56 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2009::630 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1750069997; cv=pass; b=uaDW2z4tSKAqEJddqmzS8O0WqDw0LMdGC4wCNdjJZ8w/BXjvIWnVOlGIV2PUUOenGz97JjfNj/+4rhZTwiV7LbeHrmI83uu3tn+zYap+O3Poioq5oIhJGu0+Mr9+sJ7M+YpE63qvutfSgeBqb0fpt8mW6pMtsrigtFTIPg4pMw4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1750069997; c=relaxed/simple; bh=Dlk3EfgTdqszjGeg6hgeZgmiYg5/zqRgZR0uJnpXzgQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Lw8QoWNBE1/zOFIXc+cBc5plz5fd/LUPdbeSbz8rhUFz4TeXpBXj1U93zqtcJzpWDS+6I6yKFSyBOAo3BQWVZn+vG9HjT4tvefnsnr3FF03F8CkNuUmAgIgeyh1JjcgSMhflgUI9eph5ZUOsZoEkDMfwN5KXZe5UOrv/lVsSxZs= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1004F383AD56 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AivZEplhEstRQiyHlywbDyjJ1t7mUhayRm6WBhW8snnIqLQhC5KW60dHtXKjROB9z34yCT9H7NL/maa9ZUfgYJnNC5GF6BgHrwvmJradghvvhYvxY3z2bJX86zxW6sjLPaUN43xdjECqnwNScxJdY3EgjeliFVrict+0jmZbJaevBiNLkHxJlEadGkM7l3T0ZfCwDSODVREU2ZWmfVEoSPP9AmEakSJ3+/o0MinFouwjvC4U5kWNXn+uZ1w5RTARmSxXWbZJouxx1JAUYpGAKhWFs1awr9OCcwuaL9wCUMjUwMgvJV+bIriSH05HonXOUR9SNJbgAyKmlvzsqMEBFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=inQnRMwYxKtjIO73yotJg3549Nf19VkKMeaif9JoKLA=; b=yzsHbbwqBk4eX2c/zSJ/1L867kIWlsi1/Saubba86MWfzQcdvKLVvN9I7gy/3QPnyiNQE+YWd+ttztlQqD5tHsHkkLpfd7fU6N3/jBLqcsQA8uwIkzlfmhb+q8MWpAxXV8pO0DrOnJZsKGJMMx3MAzxAaaZyTpxE04WAFAPB8NnTgFXhVvY7k9k+twUzYzV1N7ZoMeU/ZJb3I3JsR+2FqbGbuNFlDHR+zGtnyjiASFH/Rs+HoQ9WfK4fGotkdgfTLoZZsa4tWyUusAUQSDi4dXU1Db6uTirG2Z11gt6IXeIXtTsL3yEyqFfOStXEl4RpyPI8VpOoJ3IvNRwUcftkyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=efficios.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=inQnRMwYxKtjIO73yotJg3549Nf19VkKMeaif9JoKLA=; b=Ef8EVVbQjGxnCNnjiK0pDHtWyc2akSYN2WsEzCmzRyDQbffQj2QuHN3i4ECMhF0jbv2RzE/MFKEiCY6VUIpZTeKQy8Kio9BuV88JGr1QkTa623lM3A8rTd9wIRmRFT1oZfV74JeiysDGgZ2zuCwLO/5toNUEP0HBO+Xd82bLw8U= Received: from SJ0PR03CA0012.namprd03.prod.outlook.com (2603:10b6:a03:33a::17) by SJ1PR12MB6028.namprd12.prod.outlook.com (2603:10b6:a03:489::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 10:33:12 +0000 Received: from CO1PEPF000066EC.namprd05.prod.outlook.com (2603:10b6:a03:33a:cafe::18) by SJ0PR03CA0012.outlook.office365.com (2603:10b6:a03:33a::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.17 via Frontend Transport; Mon, 16 Jun 2025 10:33:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000066EC.mail.protection.outlook.com (10.167.249.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8835.15 via Frontend Transport; Mon, 16 Jun 2025 10:33:11 +0000 Received: from khazad-dum (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 16 Jun 2025 05:33:06 -0500 Date: Mon, 16 Jun 2025 11:32:59 +0100 From: Lancelot SIX To: Simon Marchi CC: Subject: Re: [PATCH v2 4/6] gdb/amd-dbgapi: pass amd_dbgapi_inferior_info to process_one_event Message-ID: References: <20250609161004.97787-4-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250609161004.97787-4-simon.marchi@efficios.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066EC:EE_|SJ1PR12MB6028:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fcf6ea1-2c9d-4378-50ae-08ddacc131ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?djJLcFNGTiswT3gxcTdzOWhrUWxLSWtNYVZYUlo2Q05td0MraHAwd1F0dEtJ?= =?utf-8?B?NkZWcmZXYjFraWNZRFM2WS8xUzU4dnVEZ3VVVmlRK0RHdlNsZDZkTGFkSUZW?= =?utf-8?B?cmxpemo2d0ZkOEJ6TzNvRklhZVFxUGxUMUFxN3hoWXM0dGIyblFCNVpRYjNq?= =?utf-8?B?QUFJTi9XazBpVy93QUVQdjlwbTdnVk52QXI3S09NOGJremxDUUt0Qy90cjNk?= =?utf-8?B?dEE5bzZIRmdNVEcybnVtMVVGTWNjSUs2cmRFRXd3bWZzSlBGQzZBclZTNDgz?= =?utf-8?B?SGdoQ1YzZk1YeGxtaTZIcmRobHZWbnBqM0lsRXA0NE5yMmtUVVpxenRrRHdO?= =?utf-8?B?UzFRVThlN1RiUDMrMEtxejVNNzVGQzdoWmZBNUNLNmdoNFRxcnFiODRUWEJU?= =?utf-8?B?UTZaZWpVRlB0bHNzNzVDd3dHb2ZQQm0wa0hyY1p6R0VPM2VvVEs1bytLNXZj?= =?utf-8?B?VnZxUTBVSGNoUHhkL0tFU1VrNFVwaHdOVGNudllNVFpzMDArZ1drSDBNRk5E?= =?utf-8?B?QUpWTFRuWng1Q1lwN3hxdzZ6eVNRYnU2RU1yTHRhaE1SQVk0V1VHaFByeXU2?= =?utf-8?B?TkVNUFkxc2luWHZFU2hJS2cyY2lNMmVDcUgvcWhFL2dSRjlTOGkrT2lSRE1B?= =?utf-8?B?K1hYd2VpSVhRUDBoQjFHUFFRMVNuSDZzUGxRSlg2NTY5RG5Dbi9LcXNyNHhz?= =?utf-8?B?UUViZG9LWUthcWQ0Mk1ibExOM1R5NDhKR3RrQUdUMkRLdlRjaVpodVdjS0ZP?= =?utf-8?B?Z1pIeW9qMDZ6bWl2cDJwakJ2cnpybXFueUgxVkJIeHk0b3ArbHM5b2tVVlRr?= =?utf-8?B?RFpuUzFudUxRVHZCT2NZWCtjSVQ3UFU3cEYxcysvbnlEelBNYVRselMxNTNW?= =?utf-8?B?RlRkWnZ6R1VkNERJVmhBMHVZUFdnN1JUYlg1SzJzWFBlU1RISEpaSjlRQ08z?= =?utf-8?B?N2RhdVVXMjVzYXdOd0Q5YmpYbXIxMTE2YXhwVXNLSVZ5YWlySUxrU0dlUFVV?= =?utf-8?B?bVJjRksveDBMRm9UWG16bXFvKzltd0ptOXBTWXk5cS91eHptMTd6eGdUa0Q3?= =?utf-8?B?Y0F2emJsUW5ZbC8zMU9ub29NaVZ5aFVLUU9wOGNxVUJWYXFtZWk2T1h2TURI?= =?utf-8?B?cnJQVWVRaW1kdTJmM1R1TFM0Zkdxc2NqMyt3bUJJb3ZMYmd1NFFucGpGTnNO?= =?utf-8?B?WVFnYVE2UHZvckNPUTc3OThPYmhCdnZzeUdKdml6MlhPMjNtYnZXMUpGM0pi?= =?utf-8?B?clNucnFmQUpCR1FNNy9WR3lsYzB0R1U4SzQzQkpHd3BKNGt0N1I5VC8xcHdh?= =?utf-8?B?WENNZUlwcmhHcDlaS1JUTDZFd1VlTkZtdEFVNHVta1dHZ0x3MEszVjFZZzRV?= =?utf-8?B?bHhKcjBUQWVDZGN2Y1FCeTQzTHF1UktEejVuVWJIaUZsL2VuTXA1U1hRbUpv?= =?utf-8?B?cEFDV25hdi9haG40SVhKaFNQcFd3T2ZVRHB4aFY3VFh4MjdoNW1ucXkzSjhJ?= =?utf-8?B?UjR1emhnRjRnaUh3RVdnRW5saWxUMXNUQzZkcXgwWHUrTFBTaG1qaGJLYWxv?= =?utf-8?B?Tmd6allVcnhPdStrdFF5THQ1M2Vmb3lTSXFzS0pEQjdVSmZCSWYxY21zN3ZN?= =?utf-8?B?TzVDU20yVDA1UDNDTm4wbEtPL3lGNDNQZnB0SzFhaEhRU2RwbldHSFVqY3BL?= =?utf-8?B?WFRoa2VrdXhaUjlIZllSc3JaSjFJb21NQ0RTcXpSbzZZODhsQ1NIaVhYRzFF?= =?utf-8?B?eGJjVlhOdXZWOTRMclpyN0dBM1UvMStRUG1sNGo5UzlhNFpsWCt6NUpwQWN3?= =?utf-8?B?a1BneTl3R3hhbnJSUkRwdkh1YjBuQ1Q4U1hiZ2pVdHFGK2lzaTBRODMyUlBX?= =?utf-8?B?SkJnc3ZRdXMzdFllL2V5RytMbWIrSjFxUjdEaStyTmZLTVFLL2VWd01WNEt4?= =?utf-8?B?S0NuQkpzODA1UFFic0kwY1BXK0dNZndMenpXbzNCOXMzemhGNENvMnlQM2g3?= =?utf-8?B?SlV0eEN4RWxzUEd2RThJa2JrMDc1ZDA1a1pvKzJBWGdlZkFPNFlnZ0RjNm0z?= =?utf-8?Q?Ptyxk0?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 10:33:11.7974 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2fcf6ea1-2c9d-4378-50ae-08ddacc131ba X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066EC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6028 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, Jun 09, 2025 at 12:09:00PM -0400, Simon Marchi wrote: > New in v2: this patch is new > > Pass the amd_dbgapi_inferior_info object from process_event_queue to > process_one_event. Since process_event_queue pulls events for one > specific inferior, we know for which inferior the event is. This > removes the need for process_one_event to do two dbgapi calls to get the > relevant pid. If also removes one inferior lookup. > Hi Simon, Minor comments below. > Change-Id: I22927e4b6251513eb3be95785082058aa3d09954 > --- > gdb/amd-dbgapi-target.c | 58 +++++++++++++++-------------------------- > 1 file changed, 21 insertions(+), 37 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 888552e00d3e..80111359c8cd 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -1143,32 +1143,14 @@ add_gpu_thread (inferior *inf, ptid_t wave_ptid) > /* Process an event that was just pulled out of the amd-dbgapi library. */ > > static void > -process_one_event (amd_dbgapi_event_id_t event_id, > +process_one_event (amd_dbgapi_inferior_info &info, > + amd_dbgapi_event_id_t event_id, > amd_dbgapi_event_kind_t event_kind) > { > /* Automatically mark this event processed when going out of scope. */ > scoped_amd_dbgapi_event_processed mark_event_processed (event_id); > > - amd_dbgapi_process_id_t process_id; > - amd_dbgapi_status_t status > - = amd_dbgapi_event_get_info (event_id, AMD_DBGAPI_EVENT_INFO_PROCESS, > - sizeof (process_id), &process_id); > - if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), event_id.handle, > - get_status_string (status)); > - > - amd_dbgapi_os_process_id_t pid; > - status = amd_dbgapi_process_get_info (process_id, > - AMD_DBGAPI_PROCESS_INFO_OS_ID, > - sizeof (pid), &pid); > - if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("process_get_info for process_%ld failed (%s)"), > - process_id.handle, get_status_string (status)); > - > - auto *proc_target = current_inferior ()->process_target (); > - inferior *inf = find_inferior_pid (proc_target, pid); > - gdb_assert (inf != nullptr); > - amd_dbgapi_inferior_info *info = get_amd_dbgapi_inferior_info (inf); > + gdb_assert (info.inf != nullptr); > > switch (event_kind) > { > @@ -1176,14 +1158,14 @@ process_one_event (amd_dbgapi_event_id_t event_id, > case AMD_DBGAPI_EVENT_KIND_WAVE_STOP: > { > amd_dbgapi_wave_id_t wave_id; > - status > + amd_dbgapi_status_t status > = amd_dbgapi_event_get_info (event_id, AMD_DBGAPI_EVENT_INFO_WAVE, > sizeof (wave_id), &wave_id); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > error (_("event_get_info for event_%ld failed (%s)"), > event_id.handle, get_status_string (status)); > > - ptid_t event_ptid = make_gpu_ptid (pid, wave_id); > + ptid_t event_ptid = make_gpu_ptid (info.inf->pid, wave_id); > target_waitstatus ws; > > amd_dbgapi_wave_stop_reasons_t stop_reason; > @@ -1224,9 +1206,10 @@ process_one_event (amd_dbgapi_event_id_t event_id, > else > ws.set_stopped (GDB_SIGNAL_0); > > - thread_info *thread = proc_target->find_thread (event_ptid); > - if (thread == nullptr) > - thread = add_gpu_thread (inf, event_ptid); > + thread_info *thread = > + info.inf->process_target()->find_thread(event_ptid); > + if (thread == nullptr) The indentation is off here. When applying the patch, GIT warns about indenting with spaces: .../binutils-gdb/rebase-apply/patch:69: indent with spaces. thread_info *thread = .../binutils-gdb/rebase-apply/patch:70: indent with spaces. info.inf->process_target()->find_thread(event_ptid); .../binutils-gdb/rebase-apply/patch:71: indent with spaces. if (thread == nullptr) warning: 3 lines add whitespace errors. Also, the `=` symbol should be after the newline, not just before it. With those style issues fixed, this looks good to me, thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > + thread = add_gpu_thread (info.inf, event_ptid); > > /* If the wave is stopped because of a software breakpoint, the > program counter needs to be adjusted so that it points to the > @@ -1248,7 +1231,7 @@ process_one_event (amd_dbgapi_event_id_t event_id, > error (_("wave_get_info for wave_%ld failed (%s)"), > wave_id.handle, get_status_string (status)); > > - info->wave_events.emplace_back (event_ptid, ws); > + info.wave_events.emplace_back (event_ptid, ws); > break; > } > > @@ -1266,7 +1249,7 @@ process_one_event (amd_dbgapi_event_id_t event_id, > When amd_dbgapi_target_breakpoint::check_status is called, the current > inferior is the inferior that hit the breakpoint, which should still be > the case now. */ > - gdb_assert (inf == current_inferior ()); > + gdb_assert (info.inf == current_inferior ()); > handle_solib_event (); > break; > > @@ -1280,22 +1263,23 @@ process_one_event (amd_dbgapi_event_id_t event_id, > { > amd_dbgapi_runtime_state_t runtime_state; > > - status = amd_dbgapi_event_get_info (event_id, > - AMD_DBGAPI_EVENT_INFO_RUNTIME_STATE, > - sizeof (runtime_state), > - &runtime_state); > + amd_dbgapi_status_t status > + = amd_dbgapi_event_get_info (event_id, > + AMD_DBGAPI_EVENT_INFO_RUNTIME_STATE, > + sizeof (runtime_state), > + &runtime_state); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > error (_("event_get_info for event_%ld failed (%s)"), > event_id.handle, get_status_string (status)); > > gdb_assert (runtime_state == AMD_DBGAPI_RUNTIME_STATE_UNLOADED); > gdb_assert > - (info->runtime_state == AMD_DBGAPI_RUNTIME_STATE_LOADED_SUCCESS); > + (info.runtime_state == AMD_DBGAPI_RUNTIME_STATE_LOADED_SUCCESS); > > - info->runtime_state = runtime_state; > + info.runtime_state = runtime_state; > > - gdb_assert (inf->target_is_pushed (&the_amd_dbgapi_target)); > - inf->unpush_target (&the_amd_dbgapi_target); > + gdb_assert (info.inf->target_is_pushed (&the_amd_dbgapi_target)); > + info.inf->unpush_target (&the_amd_dbgapi_target); > } > break; > > @@ -1367,7 +1351,7 @@ process_event_queue (amd_dbgapi_inferior_info &info, > if (event_id == AMD_DBGAPI_EVENT_NONE || event_kind == until_event_kind) > return event_id; > > - process_one_event (event_id, event_kind); > + process_one_event (info, event_id, event_kind); > } > } > > -- > 2.49.0