From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1225 invoked by alias); 1 Apr 2010 23:13:52 -0000 Received: (qmail 1006 invoked by uid 22791); 1 Apr 2010 23:13:49 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 23:13:45 +0000 Received: by vws4 with SMTP id 4so968532vws.0 for ; Thu, 01 Apr 2010 16:13:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.90.201 with HTTP; Thu, 1 Apr 2010 16:13:42 -0700 (PDT) In-Reply-To: <201004020004.45852.pedro@codesourcery.com> References: <201004012351.20183.pedro@codesourcery.com> <201004020004.45852.pedro@codesourcery.com> Date: Thu, 01 Apr 2010 23:13:00 -0000 Received: by 10.220.123.29 with SMTP id n29mr811579vcr.124.1270163622662; Thu, 01 Apr 2010 16:13:42 -0700 (PDT) Message-ID: Subject: Re: Missing 0x in phex_nz output From: "H.J. Lu" To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00035.txt.bz2 On Thu, Apr 1, 2010 at 4:04 PM, Pedro Alves wrote: > On Thursday 01 April 2010 23:54:30, H.J. Lu wrote: >> How about this one? >> > > Use hex_string instead of adding the "0x"; it does > that for you. =A0Preaproved with that change. Done. Thanks. H.J. --- >> >> -- >> H.J. >> diff --git a/gdb/remote.c b/gdb/remote.c >> index 395a56d..bb80afb 100644 >> --- a/gdb/remote.c >> +++ b/gdb/remote.c >> @@ -4882,7 +4882,7 @@ Packet: '%s'\n"), >> =A0 =A0 =A0 =A0 =A0++p; >> >> =A0 =A0 =A0 =A0 =A0if (reg =3D=3D NULL) >> - =A0 =A0 error (_("Remote sent bad register number %s: %s\n\ >> + =A0 =A0 error (_("Remote sent bad register number 0x%s: %s\n\ >> =A0Packet: '%s'\n"), >> =A0 =A0 =A0 =A0 =A0 =A0 =A0phex_nz (pnum, 0), p, buf); > > > -- > Pedro Alves > --=20 H.J.