From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16212 invoked by alias); 25 Nov 2003 23:20:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16205 invoked from network); 25 Nov 2003 23:20:23 -0000 Received: from unknown (HELO main.gmane.org) (80.91.224.249) by sources.redhat.com with SMTP; 25 Nov 2003 23:20:23 -0000 Received: from root by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1AOmTm-0007i9-00 for ; Wed, 26 Nov 2003 00:20:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gdb-patches@sources.redhat.com Received: from sea.gmane.org ([80.91.224.252]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AOmLa-0007df-00 for ; Wed, 26 Nov 2003 00:11:54 +0100 Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian)) id 1AOmLa-0003vw-00 for ; Wed, 26 Nov 2003 00:11:54 +0100 From: Thomas Fitzsimmons Subject: Re: [WIP] pending breakpoint support Date: Tue, 25 Nov 2003 23:20:00 -0000 Organization: Red Hat, Inc. Message-ID: References: <3FBAC14D.4060002@redhat.com> <20031119150659.GA14955@nevyn.them.org> <3FBBFD90.8080106@redhat.com> <3FBE95D3.4000300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@sea.gmane.org User-Agent: Pan/0.14.2 (This is not a psychotic episode. It's a cleansing moment of clarity.) X-SW-Source: 2003-11/txt/msg00586.txt.bz2 On Fri, 21 Nov 2003 17:46:43 -0500, J. Johnston wrote: > I have appended a patch to replace the previous hack. I changed the > code so it supports conditionals and doesn't fail if you specify > source:line breakpoints. I also changed the mechanism to add a new flag > to the breakpoint struct called "pending". As you will notice, this > adds a large number of checks because you can't just check for > enable_state == bp_enabled without also checking for the pending flag. > I think that having two more enable states would have been simpler, but > I will let all of you decide. With this change, you can enable/disable > the pending breakpoint and see any conditionals attached to it. Commands > should also work. > I've been using this patch since it was posted and it is very useful for both Mozilla and libgcj debugging. One minor UI nit: I don't think I should be asked whether to make a breakpoint pending; I think the "pending" message is enough (or maybe the behaviour could be configurable). In any case, even in its current early form, this patch is a huge improvement for shared-library debugging. Tom