From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aQx8LEmXiWD6LQAAWB0awg (envelope-from ) for ; Wed, 28 Apr 2021 13:11:37 -0400 Received: by simark.ca (Postfix, from userid 112) id A87671F11C; Wed, 28 Apr 2021 13:11:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2AAE21E54D for ; Wed, 28 Apr 2021 13:11:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DF34385700F; Wed, 28 Apr 2021 17:11:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4DF34385700F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619629896; bh=rbynhbetCpy+DNzxTNCUnFmAUmR9xsV340vhmS2xsbc=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Pxd8sI6DcnVIDaOcQSEzJFV9KozzsF43pQ1ZUQ5c00T9C7OeCyAw5oCXVmU4NPowR yxf31xivOyoIaqyf7uuOQeqOHVs+VYwFeKCUE6no2SeSIvGIiQdN4npqaRdyF4CgKa /EGjf3lD+zsYnf4mi+OEGcfIu5I6KBCbdikk0HdA= Received: from mail.bob131.so (server2.bob131.so [128.199.153.143]) by sourceware.org (Postfix) with ESMTPS id 341FE385700F for ; Wed, 28 Apr 2021 17:11:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 341FE385700F Received: from internal.mail.bob131.so (localhost [127.0.0.1]) by mail.bob131.so (Postfix) with ESMTP id D165A53CB4; Wed, 28 Apr 2021 17:11:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.bob131.so D165A53CB4 Date: Thu, 29 Apr 2021 03:11:29 +1000 To: Andrew Burgess Subject: Re: [PATCH v3 2/3] Guile: add {r,}value-reference-value Message-ID: References: <&e1lx8mojs1b03hu3o_asydo0za8-nyh&337akgbzjn.o13/-otj@mail.bob131.so> <20210428165945.GB2364578@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210428165945.GB2364578@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: George Barrett via Gdb-patches Reply-To: George Barrett Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wed, Apr 28, 2021 at 05:59:45PM +0100, Andrew Burgess wrote: > Thank you for doing this work. I'm sorry to be a real pain, but could > you rename the second new function to value-rvalue-reference-value > please, I think this would be inline with the existing naming > convention; the first 'value-' indicates that the function applies to > something of value type, and the rest of the name > 'rvalue-reference-value' indicates what you're going to get. No problem, thank you for your patience with me. I have no objection to the name change (in fact, I'm not sure why I thought the name I chose was an appropriate one :P) so I'll roll a v4 in a moment. > If you just make the rename as suggested, then this patch is approved. > > Thanks, > Andrew Thanks