From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5341 invoked by alias); 13 Dec 2002 20:21:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5291 invoked from network); 13 Dec 2002 20:21:04 -0000 Received: from unknown (HELO lacrosse.corp.redhat.com) (66.187.233.200) by sources.redhat.com with SMTP; 13 Dec 2002 20:21:04 -0000 Received: from free.redhat.lsd.ic.unicamp.br (aoliva2.cipe.redhat.com [10.0.1.156]) by lacrosse.corp.redhat.com (8.11.6/8.9.3) with ESMTP id gBDKL0N13186; Fri, 13 Dec 2002 15:21:00 -0500 Received: from free.redhat.lsd.ic.unicamp.br (localhost.localdomain [127.0.0.1]) by free.redhat.lsd.ic.unicamp.br (8.12.5/8.12.5) with ESMTP id gBDKKxLk027325; Fri, 13 Dec 2002 18:20:59 -0200 Received: (from aoliva@localhost) by free.redhat.lsd.ic.unicamp.br (8.12.5/8.12.5/Submit) id gBDKKwWa027225; Fri, 13 Dec 2002 18:20:58 -0200 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] frame_id_unwind() References: <3DF7A9EE.3080908@redhat.com> From: Alexandre Oliva Organization: GCC Team, Red Hat Date: Fri, 13 Dec 2002 12:21:00 -0000 In-Reply-To: <3DF7A9EE.3080908@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SW-Source: 2002-12/txt/msg00424.txt.bz2 --=-=-= Content-length: 1212 On Dec 11, 2002, Andrew Cagney wrote: > +struct frame_id ^^ > +dummy_frame_id_unwind (struct frame_info *frame, > + void **cache) > +extern struct frame_id dummy_frame_id_unwind (struct frame_info *frame, > + void **unwind_cache); > + ^^ > +struct frame_id > +frame_id_unwind (struct frame_info *frame) > +{ > + if (!frame->id_unwind_cache_p) > + { > + frame->id_unwind_cache = > + frame->id_unwind (frame, &frame->unwind_cache); [ type mismatch above ] > + frame->id_unwind_cache_p = 1; > + } > + return frame->id_unwind_cache; > +} > +/* Unwind the frame ID. Return an ID that uniquely identifies the > + caller's frame. */ > +extern struct frame_id frame_id_unwind (struct frame_info *frame); ^^ > + struct frame_id id_unwind_cache; ^^ I believe this is enough evidence that the typedef below was meant to have struct frame_id in the return type, instead of frame_info: > +typedef struct frame_info (frame_id_unwind_ftype) (struct frame_info *frame, > + void **unwind_cache); ^^^^ So I'm checking this in as obvious. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gdb-frame-id-unwind-ret-type.patch Content-length: 820 Index: gdb/ChangeLog from Alexandre Oliva * frame.h (frame_id_unwind_ftype): Fix typo in return type. Index: gdb/frame.h =================================================================== RCS file: /cvs/uberbaum/gdb/frame.h,v retrieving revision 1.49 diff -u -p -r1.49 frame.h --- gdb/frame.h 13 Dec 2002 16:40:25 -0000 1.49 +++ gdb/frame.h 13 Dec 2002 20:14:23 -0000 @@ -335,8 +335,8 @@ typedef CORE_ADDR (frame_pc_unwind_ftype /* Same as for registers above, but return the ID of the frame that called this one. */ -typedef struct frame_info (frame_id_unwind_ftype) (struct frame_info *frame, - void **unwind_cache); +typedef struct frame_id (frame_id_unwind_ftype) (struct frame_info *frame, + void **unwind_cache); /* Describe the saved registers of a frame. */ --=-=-= Content-length: 289 -- Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org} CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org} Free Software Evangelist Professional serial bug killer --=-=-=--