From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3380 invoked by alias); 11 Feb 2002 21:18:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3230 invoked from network); 11 Feb 2002 21:18:49 -0000 Received: from unknown (HELO toenail.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 11 Feb 2002 21:18:49 -0000 Received: (from fche@localhost) by toenail.toronto.redhat.com (8.11.6/8.11.6) id g1BLIlD02617; Mon, 11 Feb 2002 16:18:47 -0500 X-Authentication-Warning: toenail.toronto.redhat.com: fche set sender to fche@redhat.com using -f To: cgd@broadcom.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] make MIPS sim mips.igen model names one per line. References: Content-Type: text/plain; charset=US-ASCII From: fche@redhat.com (Frank Ch. Eigler) Date: Mon, 11 Feb 2002 13:18:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley) MIME-Version: 1.0 X-SW-Source: 2002-02/txt/msg00334.txt.bz2 cgd@broadcom.com writes: > [...] > So, right now, the mips.igen file names models supported by > instructions in one of two ways: > [...] > (i.e., one per line, or all MIPS ISAs in one line and the rest one per > line.) > > In our local source tree, we've converted it to use only the former > form. I think it's the right thing from a maintainability (fewer > conflicts/patched lines) and consistency perspective (should convert > to be consistent one way or another). > [...] I must admit I don't see the point of this specific grasp for consistency. The single-line format allows compactness; the multi-line format allows greps and other line-by-line source manipulations. These are both useful in their place. Have you actually encountered the maintainability issues you mention ([more?] "conflicts/patched lines")? Were they really troublesome? Given the preferred use of context diffs, it doesn't seem like A B CHANGE D E is any less likely to get conflicts than A,B CHANGE D,E - FChE