From: fche@cygnus.com (Frank Ch. Eigler)
To: gdb-patches@sources.redhat.com
Cc: msnyder@cygnus.com
Subject: Re: [PATCH]: multi-arch fix for monitor.c
Date: Wed, 05 Sep 2001 00:14:00 -0000 [thread overview]
Message-ID: <o5itx45ujo.fsf@toenail.to.cygnus.com> (raw)
In-Reply-To: <3907743C.BDD@cygnus.com>
msnyder wrote:
> ! static char *zerobuf;
> + if (zerobuf == NULL)
> + zerobuf = malloc (MAX_REGISTER_RAW_SIZE);
Something is still a little suspicious.
If the gdbarch were to change during run time, there is no way to
reallocate space to match the new MAX_REGISTER_RAW_SIZE. That value
is treated a de facto constant.
Is allocating a new zerobuf too at every call too much work?
- FChE
next parent reply other threads:[~2001-09-05 0:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200004262144.OAA05362@seadog.cygnus.com>
[not found] ` <3907743C.BDD@cygnus.com>
2001-09-05 0:14 ` Frank Ch. Eigler [this message]
[not found] ` <39077739.62400899@cygnus.com>
[not found] ` <39077B95.D8EA5F06@cygnus.com>
[not found] ` <39077F1C.4D2E@cygnus.com>
2001-09-05 0:16 ` Michael Snyder
2001-09-05 0:15 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=o5itx45ujo.fsf@toenail.to.cygnus.com \
--to=fche@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox