From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71706-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32117 invoked by alias); 1 Apr 2010 19:43:20 -0000
Received: (qmail 32098 invoked by uid 22791); 1 Apr 2010 19:43:19 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 19:43:09 +0000
Received: by vws4 with SMTP id 4so887559vws.0         for <gdb-patches@sourceware.org>; Thu, 01 Apr 2010 12:43:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.90.201 with HTTP; Thu, 1 Apr 2010 12:43:07 -0700 (PDT)
In-Reply-To: <201004011920.o31JKjKZ013941@glazunov.sibelius.xs4all.nl>
References: <20100303205313.GA25695@intel.com> 	 <20100401131339.GA3457@intel.com> 	 <201004011920.o31JKjKZ013941@glazunov.sibelius.xs4all.nl>
Date: Thu, 01 Apr 2010 19:43:00 -0000
Received: by 10.220.122.220 with SMTP id m28mr722311vcr.122.1270150987074;  	Thu, 01 Apr 2010 12:43:07 -0700 (PDT)
Message-ID: <o2s6dc9ffc81004011243gd199fbbbge179de8d1b84cd7b@mail.gmail.com>
Subject: Re: PING: PATCH: Support "ah", "bh", "ch", "dh" in amd64
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00025.txt.bz2

On Thu, Apr 1, 2010 at 12:20 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wr=
ote:
>> Date: Thu, 1 Apr 2010 06:13:39 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> On Wed, Mar 03, 2010 at 12:53:13PM -0800, H.J. Lu wrote:
>> > Hi,
>> >
>> > AMD64 can access "ah", "bh", "ch", "dh". =A0I missed them in my x86
>> > pseudo register support. =A0This patch adds them. OK to install?
>> >
>> > Thanks.
>> >
>> >
>> > H.J.
>> > ---
>> > gdb/
>> >
>> > 2010-03-03 =A0H.J. Lu =A0<hongjiu.lu@intel.com>
>> >
>> > =A0 =A0 * amd64-tdep.c (amd64_byte_names): Add "ah", "bh", "ch", "dh".
>> > =A0 =A0 (amd64_pseudo_register_read): Handle "ah", "bh", "ch", "dh".
>> > =A0 =A0 (amd64_pseudo_register_write): Likewise.
>> > =A0 =A0 (amd64_init_abi): Set num_byte_regs to 20.
>> >
>> > gdb/testsuite/
>> >
>> > 2010-03-03 =A0H.J. Lu =A0<hongjiu.lu@intel.com>
>> >
>> > =A0 =A0 * gdb.arch/amd64-byte.exp: Check "ah", "bh", "ch", "dh".
>> >
>>
>> PING.
>
> Sorry; this dropped off my radar;
>
> + =A0 =A0 =A0if (gpnum >=3D 16)
>
> can you replace that magic constant with a proper #define?
>

The updated on is at

http://sourceware.org/ml/gdb-patches/2010-04/msg00024.html


--=20
H.J.