From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9817 invoked by alias); 4 May 2002 00:28:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9810 invoked from network); 4 May 2002 00:28:48 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 4 May 2002 00:28:48 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 393315EA11; Fri, 3 May 2002 19:28:46 -0500 (EST) To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com, drow@mvista.com Subject: Re: RFA: Check for corruption of cv_type chain References: <200205032219.g43MJxL15375@duracef.shout.net> From: Jim Blandy Date: Fri, 03 May 2002 17:28:00 -0000 In-Reply-To: <200205032219.g43MJxL15375@duracef.shout.net> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-05/txt/msg00089.txt.bz2 Second try. 2002-05-03 Jim Blandy * gdb.c++/hang.exp: Check for corruption of the cv_type chain. * gdb.c++/hang3.C: New file. Index: gdb/testsuite/gdb.c++/hang.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/hang.exp,v retrieving revision 1.1 diff -c -r1.1 hang.exp *** gdb/testsuite/gdb.c++/hang.exp 2 May 2002 07:03:53 -0000 1.1 --- gdb/testsuite/gdb.c++/hang.exp 4 May 2002 00:27:05 -0000 *************** *** 29,41 **** set testfile hang set binfile ${objdir}/${subdir}/${testfile} ! foreach file {hang1 hang2} { ! if { [gdb_compile "${srcdir}/${subdir}/${file}.C" "${file}.o" object {debug c++}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } } ! if {[gdb_compile "hang1.o hang2.o" ${binfile} executable {debug c++}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } --- 29,41 ---- set testfile hang set binfile ${objdir}/${subdir}/${testfile} ! foreach file {hang1 hang2 hang3} { ! if {[gdb_compile "${srcdir}/${subdir}/${file}.C" "${file}.o" object {c++ debug}] != ""} { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } } ! if {[gdb_compile "hang1.o hang2.o hang3.o" ${binfile} executable {c++ debug}] != "" } { gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." } *************** *** 110,113 **** # in `cleanup_undefined_types' corrupted the target type's `cv_type' # ring, `finish_cv_type' enters an infinite loop. ! gdb_test "print var_in_b" " = 1729" "can read debug info" --- 110,128 ---- # in `cleanup_undefined_types' corrupted the target type's `cv_type' # ring, `finish_cv_type' enters an infinite loop. ! # This checks that GDB recognizes when a structure is about to be ! # overwritten, and refuses, with a complaint. ! gdb_test "print var_in_b" " = 1729" "doesn't overwrite struct type" ! ! # This checks that cleanup_undefined_types doesn't create corrupt ! # cv_type chains. Note that var_in_hang3 does need to be declared in ! # a separate compilation unit, whose psymtab depends on hang1.o's ! # psymtab. Otherwise, GDB won't call cleanup_undefined_types (as it ! # finishes hang1.o's symbols) before it calls make_cv_type (while ! # reading hang3.o's symbols). ! # ! # The bug only happens when you compile with -gstabs+; Otherwise, GCC ! # won't include the `const' qualifier on `const_B_ptr' in `hang3.o''s ! # STABS, so GDB won't try to create a const variant of the smashed ! # struct type, and get caught by the corrupted cv_type chain. ! gdb_test "print var_in_hang3" " = 42" "doesn't corrupt cv_type chain" Index: gdb/testsuite/gdb.c++/hang3.C =================================================================== RCS file: gdb/testsuite/gdb.c++/hang3.C diff -N gdb/testsuite/gdb.c++/hang3.C *** gdb/testsuite/gdb.c++/hang3.C 1 Jan 1970 00:00:00 -0000 --- gdb/testsuite/gdb.c++/hang3.C 4 May 2002 00:27:05 -0000 *************** *** 0 **** --- 1,4 ---- + #include "hang.H" + + const struct B *const_B_ptr; + int var_in_hang3 = 42;