From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19220 invoked by alias); 20 Dec 2001 20:24:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19199 invoked from network); 20 Dec 2001 20:24:44 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 20 Dec 2001 20:24:44 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 455A05E9D8; Thu, 20 Dec 2001 15:26:05 -0500 (EST) To: Lars Brinkhoff Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: char is unsigned on some architectures References: <20011219224516.AA8665E9D8@zwingli.cygnus.com> <3C21194D.4090605@cygnus.com> <85pu5as2mw.fsf@junk.nocrew.org> From: Jim Blandy Date: Thu, 20 Dec 2001 12:24:00 -0000 In-Reply-To: Lars Brinkhoff's message of 20 Dec 2001 09:43:19 +0100 Message-ID: X-Mailer: Gnus v5.3/Emacs 19.34 X-SW-Source: 2001-12/txt/msg00528.txt.bz2 Lars Brinkhoff writes: > Andrew Cagney writes: > > > ISO C specifies that `char' acts like either `signed char' or > > > `unsigned char'. At the moment, GDB assumes that `char' is `signed > > > char'. This patch allows the architecture to specify the correct > > > answer, and sets the value correctly for the IBM S/390 architecture. > > > 2001-12-19 Jim Blandy > > > * gdbarch.sh (TARGET_CHAR_SIGNED): New macro. > > > * gdbarch.c, gdbarch.h: Regenerated. > > > * gdbtypes.c (build_gdbtypes): If TARGET_CHAR_SIGNED is zero, > > > set the TYPE_FLAG_UNSIGNED bit on the type. > > > * s390-tdep.c (s390_gdbarch_init): On the S/390, characters > > > are unsigned by default. > > > > Hmm, the rs6000 and prodogy (Hmm, IBM ...) are also unsigned. > > How about ARM? I don't know anything about the ARM. If you do, well, it's a one-line patch. :)