From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4821 invoked by alias); 19 Jul 2002 19:24:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4813 invoked from network); 19 Jul 2002 19:24:36 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 19 Jul 2002 19:24:36 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 722885EA11; Fri, 19 Jul 2002 14:24:35 -0500 (EST) To: Andrew Cagney Cc: Michal Ludvig , GDB Patches Subject: Re: [RFA] dwarf2cfi.c improvements References: <3D36B967.7030205@suse.cz> <3D383267.2050207@ges.redhat.com> From: Jim Blandy Date: Fri, 19 Jul 2002 12:56:00 -0000 In-Reply-To: <3D383267.2050207@ges.redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00424.txt.bz2 Andrew Cagney writes: > > - default: /* This label is here just to avoid warning. */ > >> + default: > >> + error ("execute_stack_op: Unknown DW_OP_ value"); > >> break; > >> > > Just FYI, error messages should not be refering to a gdb internal > functions. It should probably also be slightly more descriptive > indicating that the problem is in the dwarf2 information being read in > and not in GDB. Oops. I noticed that, and then forgot to say anything about it. Thanks for catching it.