From: Jim Blandy <jimb@zwingli.cygnus.com>
To: Daniel Berlin <dan@cgsoftware.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: correctly compute addresses of embedded objects
Date: Sun, 20 May 2001 13:06:00 -0000 [thread overview]
Message-ID: <npu22gmtq3.fsf@zwingli.cygnus.com> (raw)
In-Reply-To: <87d796cff9.fsf@dynamic-addr-83-177.resnet.rochester.edu>
Dan's correct --- this patch is wrong. I withdraw it.
Daniel Berlin <dan@cgsoftware.com> writes:
> Jim Blandy <jimb@zwingli.cygnus.com> writes:
> > 2001-05-17 Jim Blandy <jimb@redhat.com>
> >
> > * valops.c (value_addr): Don't include VALUE_EMBEDDED_OFFSET in
> > the pointer value we return. It should point at the embedded
> > object ARG1 represents, not at the enclosing object ARG1 might
> > also be holding.
>
> Errr, value_addr gives back something for which arg1 is the
> contents.
>
> We then set the VALUE_POINTED_TO_OFFSET to the VALUE_EMBEDDED_OFFSET of
> arg1, to keep track of the relative location of the subobject in the
> full object.
> In other words, the embedded object is at the address of the enclosing
> object + the embedded offset .
> So the actual pointer *should* include the embedded offset, because
> this is where the embedded object really is.
prev parent reply other threads:[~2001-05-20 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-18 17:29 Jim Blandy
2001-05-18 18:10 ` Daniel Berlin
2001-05-20 13:06 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=npu22gmtq3.fsf@zwingli.cygnus.com \
--to=jimb@zwingli.cygnus.com \
--cc=dan@cgsoftware.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox