From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10482 invoked by alias); 10 May 2002 18:33:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10436 invoked from network); 10 May 2002 18:33:27 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 10 May 2002 18:33:27 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id AAF3C5EA11; Fri, 10 May 2002 13:33:25 -0500 (EST) To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: don't xfail ptype test References: <200205101655.g4AGtIn01593@duracef.shout.net> From: Jim Blandy Date: Fri, 10 May 2002 11:33:00 -0000 In-Reply-To: <200205101655.g4AGtIn01593@duracef.shout.net> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-05/txt/msg00355.txt.bz2 Michael Elizabeth Chastain writes: > This patch is returned for more work. > > Hmmm. I agree that this is a bug: > > (gdb) ptype &*"foo" > type = char [4] > > I get that behavior in all of my configurations. > > The problem is simply converting XFAIL -> FAIL. That's correct, but it > doesn't leave a good enough trail for people doing regression analysis. > > Could you please file a bug report and then add a comment to the > test script with the bug ID number in it: > > # setup_kfail "gdb/1234" > > The bug report can say that this bug is also present in 5.2. > > I am willing to file the bug report this evening if you want me to > do that part. > > Michael C Okay, how's the below? What's setup_kfail? Where can I find a description of it? 2002-05-10 Jim Blandy * gdb.base/printcmds.exp: Don't xfail the ptype command. This is a bug. Index: gdb/testsuite/gdb.base/printcmds.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/printcmds.exp,v retrieving revision 1.7 diff -c -r1.7 printcmds.exp *** gdb/testsuite/gdb.base/printcmds.exp 4 May 2002 15:18:21 -0000 1.7 --- gdb/testsuite/gdb.base/printcmds.exp 10 May 2002 18:05:04 -0000 *************** *** 626,633 **** gdb_test "ptype \"foo\"" " = char \\\[4\\\]" gdb_test "p *\"foo\"" " = 102 'f'" gdb_test "ptype *\"foo\"" " = char" gdb_test "p &*\"foo\"" " = \"foo\"" - setup_xfail "*-*-*" gdb_test "ptype &*\"foo\"" "type = char \\*" gdb_test "p (char *)\"foo\"" " = \"foo\"" } --- 626,633 ---- gdb_test "ptype \"foo\"" " = char \\\[4\\\]" gdb_test "p *\"foo\"" " = 102 'f'" gdb_test "ptype *\"foo\"" " = char" + # setup_kfail "gdb/538" gdb_test "p &*\"foo\"" " = \"foo\"" gdb_test "ptype &*\"foo\"" "type = char \\*" gdb_test "p (char *)\"foo\"" " = \"foo\"" }