From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23529 invoked by alias); 20 Dec 2001 03:26:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23508 invoked from network); 20 Dec 2001 03:26:33 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 20 Dec 2001 03:26:33 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 7B2BE5E9D8; Wed, 19 Dec 2001 22:27:53 -0500 (EST) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: char is unsigned on some architectures References: <20011219224516.AA8665E9D8@zwingli.cygnus.com> <3C21194D.4090605@cygnus.com> From: Jim Blandy Date: Wed, 19 Dec 2001 19:26:00 -0000 In-Reply-To: Andrew Cagney's message of Wed, 19 Dec 2001 22:48:45 +0000 Message-ID: X-Mailer: Gnus v5.3/Emacs 19.34 X-SW-Source: 2001-12/txt/msg00495.txt.bz2 Andrew Cagney writes: > Hmm, the rs6000 and prodogy (Hmm, IBM ...) are also unsigned. Want to > add that ``obvious'' tweek? Okay, here's the patch I actually committed: 2001-12-19 Jim Blandy * gdbarch.sh (TARGET_CHAR_SIGNED): New macro. * gdbarch.c, gdbarch.h: Regenerated. * gdbtypes.c (build_gdbtypes): If TARGET_CHAR_SIGNED is zero, set the TYPE_FLAG_UNSIGNED bit on the type. * s390-tdep.c (s390_gdbarch_init): On the S/390, characters are unsigned by default. * rs6000-tdep.c (rs6000_gdbarch_init): Same for PowerPC and RS6000. Index: gdb/gdbarch.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/gdbarch.c,v retrieving revision 2.113 diff -c -r2.113 gdbarch.c *** gdb/gdbarch.c 2001/12/19 21:20:29 2.113 --- gdb/gdbarch.c 2001/12/20 03:16:50 *************** *** 144,149 **** --- 144,150 ---- int ptr_bit; int addr_bit; int bfd_vma_bit; + int char_signed; int ieee_float; gdbarch_read_pc_ftype *read_pc; gdbarch_write_pc_ftype *write_pc; *************** *** 285,290 **** --- 286,292 ---- 8 * sizeof (void*), 8 * sizeof (void*), 8 * sizeof (void*), + 1, 0, 0, 0, *************** *** 446,451 **** --- 448,454 ---- current_gdbarch->long_double_bit = 2*TARGET_DOUBLE_BIT; current_gdbarch->ptr_bit = TARGET_INT_BIT; current_gdbarch->bfd_vma_bit = TARGET_ARCHITECTURE->bits_per_address; + current_gdbarch->char_signed = -1; current_gdbarch->read_pc = generic_target_read_pc; current_gdbarch->write_pc = generic_target_write_pc; current_gdbarch->read_fp = generic_target_read_fp; *************** *** 561,566 **** --- 564,571 ---- if (gdbarch->addr_bit == 0) gdbarch->addr_bit = TARGET_PTR_BIT; /* Skip verify of bfd_vma_bit, invalid_p == 0 */ + if (gdbarch->char_signed == -1) + gdbarch->char_signed = 1; /* Skip verify of ieee_float, invalid_p == 0 */ /* Skip verify of read_pc, invalid_p == 0 */ /* Skip verify of write_pc, invalid_p == 0 */ *************** *** 1867,1872 **** --- 1872,1885 ---- "gdbarch_dump: TARGET_BYTE_ORDER = %ld\n", (long) TARGET_BYTE_ORDER); #endif + #ifdef TARGET_CHAR_SIGNED + fprintf_unfiltered (file, + "gdbarch_dump: TARGET_CHAR_SIGNED # %s\n", + XSTRING (TARGET_CHAR_SIGNED)); + fprintf_unfiltered (file, + "gdbarch_dump: TARGET_CHAR_SIGNED = %d\n", + (long) TARGET_CHAR_SIGNED); + #endif #ifdef TARGET_DOUBLE_BIT fprintf_unfiltered (file, "gdbarch_dump: TARGET_DOUBLE_BIT # %s\n", *************** *** 2263,2268 **** --- 2276,2299 ---- int bfd_vma_bit) { gdbarch->bfd_vma_bit = bfd_vma_bit; + } + + int + gdbarch_char_signed (struct gdbarch *gdbarch) + { + if (gdbarch->char_signed == -1) + internal_error (__FILE__, __LINE__, + "gdbarch: gdbarch_char_signed invalid"); + if (gdbarch_debug >= 2) + fprintf_unfiltered (gdb_stdlog, "gdbarch_char_signed called\n"); + return gdbarch->char_signed; + } + + void + set_gdbarch_char_signed (struct gdbarch *gdbarch, + int char_signed) + { + gdbarch->char_signed = char_signed; } int Index: gdb/gdbarch.h =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/gdbarch.h,v retrieving revision 2.104 diff -c -r2.104 gdbarch.h *** gdb/gdbarch.h 2001/12/11 00:04:41 2.104 --- gdb/gdbarch.h 2001/12/20 03:16:51 *************** *** 287,292 **** --- 287,310 ---- #endif #endif + /* One if `char' acts like `signed char', zero if `unsigned char'. */ + + /* Default (value) for non- multi-arch platforms. */ + #if (!GDB_MULTI_ARCH) && !defined (TARGET_CHAR_SIGNED) + #define TARGET_CHAR_SIGNED (1) + #endif + + extern int gdbarch_char_signed (struct gdbarch *gdbarch); + extern void set_gdbarch_char_signed (struct gdbarch *gdbarch, int char_signed); + #if (GDB_MULTI_ARCH > GDB_MULTI_ARCH_PARTIAL) && defined (TARGET_CHAR_SIGNED) + #error "Non multi-arch definition of TARGET_CHAR_SIGNED" + #endif + #if GDB_MULTI_ARCH + #if (GDB_MULTI_ARCH > GDB_MULTI_ARCH_PARTIAL) || !defined (TARGET_CHAR_SIGNED) + #define TARGET_CHAR_SIGNED (gdbarch_char_signed (current_gdbarch)) + #endif + #endif + /* Default (value) for non- multi-arch platforms. */ #if (!GDB_MULTI_ARCH) && !defined (IEEE_FLOAT) #define IEEE_FLOAT (0) Index: gdb/gdbarch.sh =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/gdbarch.sh,v retrieving revision 2.92 diff -c -r2.92 gdbarch.sh *** gdb/gdbarch.sh 2001/12/19 21:20:29 2.92 --- gdb/gdbarch.sh 2001/12/20 03:16:51 *************** *** 384,389 **** --- 384,392 ---- # Number of bits in a BFD_VMA for the target object file format. v::TARGET_BFD_VMA_BIT:int:bfd_vma_bit::::8 * sizeof (void*):TARGET_ARCHITECTURE->bits_per_address::0 # + # One if \`char' acts like \`signed char', zero if \`unsigned char'. + v::TARGET_CHAR_SIGNED:int:char_signed::::1:-1:1::%d:: + # v::IEEE_FLOAT:int:ieee_float::::0:0::0::: # f::TARGET_READ_PC:CORE_ADDR:read_pc:ptid_t ptid:ptid::0:generic_target_read_pc::0 Index: gdb/gdbtypes.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/gdbtypes.c,v retrieving revision 2.127 diff -c -r2.127 gdbtypes.c *** gdb/gdbtypes.c 2001/12/19 21:20:29 2.127 --- gdb/gdbtypes.c 2001/12/20 03:16:53 *************** *** 3029,3035 **** "void", (struct objfile *) NULL); builtin_type_char = init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT, ! TYPE_FLAG_NOSIGN, "char", (struct objfile *) NULL); builtin_type_true_char = init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT, --- 3029,3036 ---- "void", (struct objfile *) NULL); builtin_type_char = init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT, ! (TYPE_FLAG_NOSIGN ! | (TARGET_CHAR_SIGNED ? 0 : TYPE_FLAG_UNSIGNED)), "char", (struct objfile *) NULL); builtin_type_true_char = init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT, Index: gdb/rs6000-tdep.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/rs6000-tdep.c,v retrieving revision 2.129 diff -c -r2.129 rs6000-tdep.c *** gdb/rs6000-tdep.c 2001/12/19 21:20:29 2.129 --- gdb/rs6000-tdep.c 2001/12/20 03:16:54 *************** *** 2298,2303 **** --- 2298,2304 ---- set_gdbarch_float_bit (gdbarch, 4 * TARGET_CHAR_BIT); set_gdbarch_double_bit (gdbarch, 8 * TARGET_CHAR_BIT); set_gdbarch_long_double_bit (gdbarch, 8 * TARGET_CHAR_BIT); + set_gdbarch_char_signed (gdbarch, 0); set_gdbarch_use_generic_dummy_frames (gdbarch, 1); set_gdbarch_call_dummy_length (gdbarch, 0); Index: gdb/s390-tdep.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/s390-tdep.c,v retrieving revision 2.32 diff -c -r2.32 s390-tdep.c *** gdb/s390-tdep.c 2001/12/19 23:08:16 2.32 --- gdb/s390-tdep.c 2001/12/20 03:16:55 *************** *** 1763,1768 **** --- 1763,1769 ---- gdbarch = gdbarch_alloc (&info, NULL); set_gdbarch_believe_pcc_promotion (gdbarch, 0); + set_gdbarch_char_signed (gdbarch, 0); set_gdbarch_frame_args_skip (gdbarch, 0); set_gdbarch_frame_args_address (gdbarch, s390_frame_args_address);