From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30837 invoked by alias); 10 Dec 2001 20:49:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30761 invoked from network); 10 Dec 2001 20:49:26 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 10 Dec 2001 20:49:26 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 62AA05E9D8; Mon, 10 Dec 2001 15:50:44 -0500 (EST) To: fnf@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Make lookup_minimal_symbol calls consistent References: <200112101912.fBAJCWG31040@fishpond.ninemoons.com> From: Jim Blandy Date: Mon, 10 Dec 2001 12:49:00 -0000 In-Reply-To: Fred Fish's message of Mon, 10 Dec 2001 12:12:31 -0700 (MST) Message-ID: X-Mailer: Gnus v5.3/Emacs 19.34 X-SW-Source: 2001-12/txt/msg00284.txt.bz2 Approved. Fred Fish writes: > > Most places in gdb call lookup_minimal_symbol with NULL for arguments > that are unspecified, however a few places still use 0. This patch > makes all the calls consistently use NULL. > > -Fred > > 2001-12-10 Fred Fish > > * arm-linux-tdep.c (skip_hurd_resolver): Use NULL rather than > zero in args to lookup_minimal_symbol. > * linespec.c (decode_line_1): Ditto. > * i386-linux-tdep.c (skip_hurd_resolver): Ditto. > * minsyms.c (find_stab_function_addr): Ditto. > * symfile.c (simple_read_overlay_table): Ditto. > (simple_read_overlay_region_table): Ditto. > > Index: arm-linux-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/arm-linux-tdep.c,v > retrieving revision 1.11 > diff -u -p -r1.11 arm-linux-tdep.c > --- arm-linux-tdep.c 2001/08/21 04:31:32 1.11 > +++ arm-linux-tdep.c 2001/12/10 18:25:01 > @@ -402,7 +402,7 @@ skip_hurd_resolver (CORE_ADDR pc) > if (resolver) > { > struct minimal_symbol *fixup > - = lookup_minimal_symbol ("fixup", 0, objfile); > + = lookup_minimal_symbol ("fixup", NULL, objfile); > > if (fixup && SYMBOL_VALUE_ADDRESS (fixup) == pc) > return (SAVED_PC_AFTER_CALL (get_current_frame ())); > Index: i386-linux-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/i386-linux-tdep.c,v > retrieving revision 1.9 > diff -u -p -r1.9 i386-linux-tdep.c > --- i386-linux-tdep.c 2001/11/04 14:06:16 1.9 > +++ i386-linux-tdep.c 2001/12/10 18:25:02 > @@ -458,7 +458,7 @@ skip_hurd_resolver (CORE_ADDR pc) > if (resolver) > { > struct minimal_symbol *fixup > - = lookup_minimal_symbol ("fixup", 0, objfile); > + = lookup_minimal_symbol ("fixup", NULL, objfile); > > if (fixup && SYMBOL_VALUE_ADDRESS (fixup) == pc) > return (SAVED_PC_AFTER_CALL (get_current_frame ())); > Index: linespec.c > =================================================================== > RCS file: /cvs/src/src/gdb/linespec.c,v > retrieving revision 1.12 > diff -u -p -r1.12 linespec.c > --- linespec.c 2001/11/10 21:34:56 1.12 > +++ linespec.c 2001/12/10 18:25:05 > @@ -1115,7 +1115,7 @@ decode_line_1 (char **argptr, int funfir > goto symbol_found; > > /* If symbol was not found, look in minimal symbol tables */ > - msymbol = lookup_minimal_symbol (copy, 0, 0); > + msymbol = lookup_minimal_symbol (copy, NULL, NULL); > /* Min symbol was found --> jump to minsym processing. */ > if (msymbol) > goto minimal_symbol_found; > Index: minsyms.c > =================================================================== > RCS file: /cvs/src/src/gdb/minsyms.c,v > retrieving revision 1.18 > diff -u -p -r1.18 minsyms.c > --- minsyms.c 2001/10/12 19:07:07 1.18 > +++ minsyms.c 2001/12/10 18:25:07 > @@ -547,14 +547,14 @@ find_stab_function_addr (char *namestrin > { > /* Try again without the filename. */ > p[n] = 0; > - msym = lookup_minimal_symbol (p, 0, objfile); > + msym = lookup_minimal_symbol (p, NULL, objfile); > } > if (msym == NULL && filename != NULL) > { > /* And try again for Sun Fortran, but without the filename. */ > p[n] = '_'; > p[n + 1] = 0; > - msym = lookup_minimal_symbol (p, 0, objfile); > + msym = lookup_minimal_symbol (p, NULL, objfile); > } > > return msym == NULL ? 0 : SYMBOL_VALUE_ADDRESS (msym); > Index: symfile.c > =================================================================== > RCS file: /cvs/src/src/gdb/symfile.c,v > retrieving revision 1.44 > diff -u -p -r1.44 symfile.c > --- symfile.c 2001/12/02 22:38:23 1.44 > +++ symfile.c 2001/12/10 18:25:15 > @@ -3026,7 +3026,7 @@ simple_read_overlay_table (void) > struct minimal_symbol *novlys_msym, *ovly_table_msym; > > simple_free_overlay_table (); > - novlys_msym = lookup_minimal_symbol ("_novlys", 0, 0); > + novlys_msym = lookup_minimal_symbol ("_novlys", NULL, NULL); > if (! novlys_msym) > { > error ("Error reading inferior's overlay table: " > @@ -3035,7 +3035,7 @@ simple_read_overlay_table (void) > return 0; > } > > - ovly_table_msym = lookup_minimal_symbol ("_ovly_table", 0, 0); > + ovly_table_msym = lookup_minimal_symbol ("_ovly_table", NULL, NULL); > if (! ovly_table_msym) > { > error ("Error reading inferior's overlay table: couldn't find " > @@ -3064,7 +3064,7 @@ simple_read_overlay_region_table (void) > struct minimal_symbol *msym; > > simple_free_overlay_region_table (); > - msym = lookup_minimal_symbol ("_novly_regions", 0, 0); > + msym = lookup_minimal_symbol ("_novly_regions", NULL, NULL); > if (msym != NULL) > cache_novly_regions = read_memory_integer (SYMBOL_VALUE_ADDRESS (msym), 4); > else > @@ -3072,7 +3072,7 @@ simple_read_overlay_region_table (void) > cache_ovly_region_table = (void *) xmalloc (cache_novly_regions * 12); > if (cache_ovly_region_table != NULL) > { > - msym = lookup_minimal_symbol ("_ovly_region_table", 0, 0); > + msym = lookup_minimal_symbol ("_ovly_region_table", NULL, NULL); > if (msym != NULL) > { > cache_ovly_region_table_base = SYMBOL_VALUE_ADDRESS (msym); > @@ -3142,7 +3142,7 @@ simple_overlay_update (struct obj_sectio > if (cache_ovly_table != NULL) > /* Does its cached location match what's currently in the symtab? */ > if (cache_ovly_table_base == > - SYMBOL_VALUE_ADDRESS (lookup_minimal_symbol ("_ovly_table", 0, 0))) > + SYMBOL_VALUE_ADDRESS (lookup_minimal_symbol ("_ovly_table", NULL, NULL))) > /* Then go ahead and try to look up this single section in the cache */ > if (simple_overlay_update_1 (osect)) > /* Found it! We're done. */ > >