From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17004-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30467 invoked by alias); 18 Jul 2002 22:14:16 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30460 invoked from network); 18 Jul 2002 22:14:15 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 18 Jul 2002 22:14:15 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id 3DEF25EA11; Thu, 18 Jul 2002 17:14:14 -0500 (EST)
To: Michal Ludvig <mludvig@suse.cz>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] dwarf2cfi.c improvements
References: <3D36B967.7030205@suse.cz>
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 18 Jul 2002 16:53:00 -0000
In-Reply-To: <3D36B967.7030205@suse.cz>
Message-ID: <nplm88fzuy.fsf@zwingli.cygnus.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-07/txt/msg00407.txt.bz2


Sure --- looks good to me.

Michal Ludvig <mludvig@suse.cz> writes:

> Hi all,
> this patch adds an error() call when there is an unknown DW_OP_ value
> in a debug_frame section. Next it initialises return value CFA so that
> it isn't used uninitialised when the switch{} finishes on default
> label.
> Easy. Nothing to be broken in here. OK to commit?
> 
> Michal Ludvig
> -- 
> * SuSE CR, s.r.o     * mludvig@suse.cz
> * +420 2 9654 5373   * http://www.suse.cz
> 2002-07-17  Michal Ludvig  <michal@suse.cz>
> 
> 	* dwarf2cfi.c (execute_stack_op): Complain on unknown DW_OP_ value.
> 	(update_context): Initialise cfa variable.
> 
> Index: dwarf2cfi.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2cfi.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 dwarf2cfi.c
> --- dwarf2cfi.c	15 Jul 2002 16:01:31 -0000	1.15
> +++ dwarf2cfi.c	18 Jul 2002 12:35:40 -0000
> @@ -1227,7 +1227,8 @@ execute_stack_op (struct objfile *objfil
>  	      case DW_OP_ne:
>  		result = (LONGEST) first != (LONGEST) second;
>  		break;
> -	      default:		/* This label is here just to avoid warning.  */
> +	      default:
> +		error ("execute_stack_op: Unknown DW_OP_ value");
>  		break;
>  	      }
>  	  }
> @@ -1271,7 +1272,7 @@ static void
>  update_context (struct context *context, struct frame_state *fs, int chain)
>  {
>    struct context *orig_context;
> -  CORE_ADDR cfa;
> +  CORE_ADDR cfa = 0;
>    long i;
>  
>    unwind_tmp_obstack_init ();