From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11463-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32499 invoked by alias); 20 Dec 2001 20:57:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32455 invoked from network); 20 Dec 2001 20:57:35 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 20 Dec 2001 20:57:35 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id E47A45E9D8; Thu, 20 Dec 2001 15:58:55 -0500 (EST)
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: S/390: don't try to read zero bytes
References: <20011220085726.B6FA35E9D8@zwingli.cygnus.com>
	<3C21C707.2050609@cygnus.com>
From: Jim Blandy <jimb@zwingli.cygnus.com>
Date: Thu, 20 Dec 2001 12:57:00 -0000
In-Reply-To: Andrew Cagney's message of Thu, 20 Dec 2001 11:09:59 +0000
Message-ID: <npitb1wquo.fsf@zwingli.cygnus.com>
X-Mailer: Gnus v5.3/Emacs 19.34
X-SW-Source: 2001-12/txt/msg00530.txt.bz2


Andrew Cagney <ac131313@cygnus.com> writes:
> > 2001-12-20  Jim Blandy  <jimb@redhat.com>
> > 
> > * s390-tdep.c (s390_readinstruction): Don't call
> > 	info->read_memory_func to read zero bytes.  Some targets'
> > 	xfer_memory functions can't cope with that.
> > 
> 
> 
> Jim, which?
> 
> While slightly stupid, the target should be able to handle that.

Oh, wait, I understand now.

A target's to_xfer_memory function is supposed to return the number of
bytes transferred, or zero if it can't transfer the bytes.  If you
make a zero-length request, there's no way for it to indicate success.
D'oh!