From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11193-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32120 invoked by alias); 10 Dec 2001 03:04:11 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32099 invoked from network); 10 Dec 2001 03:04:09 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 10 Dec 2001 03:04:09 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id ED92E5E9D8; Sun,  9 Dec 2001 22:05:14 -0500 (EST)
To: fnf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Remove another handcrafted type initialization
References: <200112090700.fB970F116869@fishpond.ninemoons.com>
From: Jim Blandy <jimb@zwingli.cygnus.com>
Date: Sun, 09 Dec 2001 19:04:00 -0000
In-Reply-To: Fred Fish's message of Sun, 9 Dec 2001 00:00:15 -0700 (MST)
Message-ID: <npg06j3hcl.fsf@zwingli.cygnus.com>
X-Mailer: Gnus v5.3/Emacs 19.34
X-SW-Source: 2001-12/txt/msg00260.txt.bz2


Approved.

Fred Fish <fnf@ns1.ninemoons.com> writes:

> 
> Here's another case of gdb type initialization than can be handled
> by init_type().
> 
> -Fred
> 
> 2001-12-08  Fred Fish  <fnf@redhat.com>
> 
> 	* gdbtypes.c (allocate_stub_method): Replace hand crafted type
> 	initialization with call to the init_type() function.
> 
> Index: gdbtypes.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtypes.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 gdbtypes.c
> --- gdbtypes.c	2001/12/07 22:11:51	1.29
> +++ gdbtypes.c	2001/12/09 07:03:44
> @@ -542,13 +542,11 @@ allocate_stub_method (struct type *type)
>  {
>    struct type *mtype;
>  
> -  mtype = alloc_type (TYPE_OBJFILE (type));
> +  mtype = init_type (TYPE_CODE_METHOD, 1, TYPE_FLAG_STUB, NULL,
> +		     TYPE_OBJFILE (type));
>    TYPE_TARGET_TYPE (mtype) = type;
>    /*  _DOMAIN_TYPE (mtype) = unknown yet */
>    /*  _ARG_TYPES (mtype) = unknown yet */
> -  TYPE_FLAGS (mtype) = TYPE_FLAG_STUB;
> -  TYPE_CODE (mtype) = TYPE_CODE_METHOD;
> -  TYPE_LENGTH (mtype) = 1;
>    return (mtype);
>  }
>  
>