From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13916-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 28028 invoked by alias); 4 Apr 2002 22:24:20 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 28021 invoked from network); 4 Apr 2002 22:24:20 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 4 Apr 2002 22:24:20 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id 7CF575EA11; Thu,  4 Apr 2002 17:24:18 -0500 (EST)
To: Jim Ingham <jingham@apple.com>
Cc: Daniel Jacobowitz <drow@mvista.com>,
	gdb-patches@sources.redhat.com
Subject: Re: Trivial fix in value_sub
References: <5BEA75A4-4815-11D6-86BE-000393540DDC@apple.com>
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 04 Apr 2002 14:24:00 -0000
In-Reply-To: <5BEA75A4-4815-11D6-86BE-000393540DDC@apple.com>
Message-ID: <npelhvayr1.fsf@zwingli.cygnus.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-04/txt/msg00137.txt.bz2


Jim Ingham <jingham@apple.com> writes:
> Okay, so to be consistent, I throw errors in both value_add &
> value_sub.  How about this:

Superb!  Could you move the "fix up my size or report an error" code
into a function instead of repeating it?