From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30006 invoked by alias); 27 Nov 2001 21:16:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29964 invoked from network); 27 Nov 2001 21:16:36 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by hostedprojects.ges.redhat.com with SMTP; 27 Nov 2001 21:16:36 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id EEC9D5E9D8; Tue, 27 Nov 2001 16:17:51 -0500 (EST) To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/c++] Fix printing classes with virtual base classes References: <20011126201945.A27754@nevyn.them.org> <20011127020634.A10010@nevyn.them.org> From: Jim Blandy Date: Wed, 14 Nov 2001 22:39:00 -0000 In-Reply-To: Daniel Jacobowitz's message of Tue, 27 Nov 2001 02:06:34 -0500 Message-ID: X-Mailer: Gnus v5.3/Emacs 19.34 X-SW-Source: 2001-11/txt/msg00294.txt.bz2 These are two independent fixes, right? I understand GDB may need them both before it works correctly; I'm asking if each of them is a correct change in its own right. If so, could you show me a test case that each change fixes? Daniel Jacobowitz writes: > 2001-11-26 Daniel Jacobowitz > > * values.c (value_primitive_field): Add embedded_offset to the > address of structure members. > * gnu-v3-abi.c (gnuv3_rtti_type): Cast to base type before > attempting to access vtable pointer. Set using_enc_p if we cast. > (gnuv3_virtual_fn_field): Call value_cast with structure rather than > structure pointer. Cast to base type before attempting to access > vtable pointer. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Blandy To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/c++] Fix printing classes with virtual base classes Date: Tue, 27 Nov 2001 13:16:00 -0000 Message-ID: References: <20011126201945.A27754@nevyn.them.org> <20011127020634.A10010@nevyn.them.org> X-SW-Source: 2001-11/msg00509.html Message-ID: <20011127131600.tSQxK93gPygOEAOO9qyW-j-9LP629aqWydGJ6aDHdSI@z> These are two independent fixes, right? I understand GDB may need them both before it works correctly; I'm asking if each of them is a correct change in its own right. If so, could you show me a test case that each change fixes? Daniel Jacobowitz writes: > 2001-11-26 Daniel Jacobowitz > > * values.c (value_primitive_field): Add embedded_offset to the > address of structure members. > * gnu-v3-abi.c (gnuv3_rtti_type): Cast to base type before > attempting to access vtable pointer. Set using_enc_p if we cast. > (gnuv3_virtual_fn_field): Call value_cast with structure rather than > structure pointer. Cast to base type before attempting to access > vtable pointer.