From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11830-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 31805 invoked by alias); 11 Jan 2002 02:42:15 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 31728 invoked from network); 11 Jan 2002 02:42:11 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 11 Jan 2002 02:42:11 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id DB0BC5E9D8; Thu, 10 Jan 2002 21:43:34 -0500 (EST)
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite] Fix completion.exp on relative srcdir path
References: <20020109204006.A21094@nevyn.them.org>
From: Jim Blandy <jimb@zwingli.cygnus.com>
Date: Thu, 10 Jan 2002 18:42:00 -0000
In-Reply-To: Daniel Jacobowitz's message of Wed, 9 Jan 2002 20:40:06 -0500
Message-ID: <npd70hsj3d.fsf@zwingli.cygnus.com>
X-Mailer: Gnus v5.3/Emacs 19.34
X-SW-Source: 2002-01/txt/msg00275.txt.bz2


Daniel Jacobowitz <drow@mvista.com> writes:
> I always configure with relative paths - srcdir = ../../../src/gdb/testsuite
> or so.  That caused a bogus failure.  Is this patch OK?

What's behind the `cd ${objdir}' there that you're not doing anything
with?  Is the patch incomplete, or does it need to be cleaned up?

If you address that, and add a comment explaining why what you're
doing is necessary, then this patch looks good.



> 
> -- 
> Daniel Jacobowitz                           Carnegie Mellon University
> MontaVista Software                         Debian GNU/Linux Developer
> 
> 2002-01-09  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* gdb.base/completion.exp: Expand ${srcdir} to an absolute path.
> 
> Index: completion.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/completion.exp,v
> retrieving revision 1.10
> diff -u -p -r1.10 completion.exp
> --- completion.exp	2001/12/17 22:58:42	1.10
> +++ completion.exp	2002/01/10 01:37:15
> @@ -656,8 +656,13 @@ gdb_expect  {
>          timeout         { fail "(timeout) complete 'file ./Make'" }
>          }
>  
> +set mydir [pwd]
> +cd ${objdir}
> +cd ${srcdir}
> +set fullsrcdir [pwd]
> +cd ${mydir}
>  
> -gdb_test "cd ${srcdir}" "Working directory ${srcdir}.*" "cd to \${srcdir}"
> +gdb_test "cd ${fullsrcdir}" "Working directory ${fullsrcdir}.*" "cd to \${srcdir}"
>  send_gdb "file ./gdb.base/compl\t"
>  sleep 1
>  gdb_expect  {
>