From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10139 invoked by alias); 26 Mar 2002 23:21:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10045 invoked from network); 26 Mar 2002 23:21:26 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 26 Mar 2002 23:21:26 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 382125EA11; Tue, 26 Mar 2002 18:21:25 -0500 (EST) To: Daniel Berlin Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Let dwarf2 CFI's execute_stack_op be used outside of CFI References: From: Jim Blandy Date: Tue, 26 Mar 2002 15:21:00 -0000 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-03/txt/msg00510.txt.bz2 Daniel Berlin writes: > On 26 Mar 2002, Jim Blandy wrote: > > Actually, Daniel, I'm sorry --- I've re-read the change more > > carefully, and I've gotten more confused than I was before. > > > > You've changed the Dwarf 2 location expression evaluator to consult > > the current register values --- not the values of the registers with > > respect to a specific stack frame. I can't think of any situations in > > which this the correct behavior. Can you explain more about the > > contexts in which this change is useful? It seems to me that it's > > wrong in most of the cases I can think of. It really needs to take a > > frame argument, or at the very least, read registers from the selected > > frame (although that's kind of gross and global-variable-ish). > > Whoops. > You're right. > I must have merged it while on crack or something. > I *meant* to add the frame argument, and only require *either* the > context argument (Which is what it currently takes, a CFA context) or the > frame, but it looks like I messed up. > > What it *should* look like is closer to the one from the WIP i sent. It > should call get_saved_register with the frame argument if the context is > null, or get_reg with the context argument if the context is not null. Okay --- that makes more sense. I started reviewing the WIP, but I got interrupted. Do you want to extract something from that and post it as a non-WIP patch?