From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15272-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 9284 invoked by alias); 10 May 2002 03:45:41 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9277 invoked from network); 10 May 2002 03:45:38 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 10 May 2002 03:45:38 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id A67735EA11; Thu,  9 May 2002 22:45:37 -0500 (EST)
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: remember dwarf_line_size
References: <20020509233145.E23A45EA11@zwingli.cygnus.com>
	<3CDB39C3.6030603@cygnus.com>
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 09 May 2002 20:45:00 -0000
In-Reply-To: <3CDB39C3.6030603@cygnus.com>
Message-ID: <np661wbr8e.fsf@zwingli.cygnus.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-05/txt/msg00320.txt.bz2

Andrew Cagney <ac131313@cygnus.com> writes:

> > The change I committed May 6 to dwarf2read.c introduced the new
> > function dwarf_decode_line_header.  That contained a bunch of
> > consistency checks which assumed that dwarf_line_size is actually
> > preserved between the partial symbol scan and the full symbol read.
> > It isn't.
> 
> BTW,
> 
> >   #define DWARF_ABBREV_BUFFER(p) (PST_PRIVATE(p)->dwarf_abbrev_buffer)
> >   #define DWARF_ABBREV_SIZE(p) (PST_PRIVATE(p)->dwarf_abbrev_size)
> >   #define DWARF_LINE_BUFFER(p) (PST_PRIVATE(p)->dwarf_line_buffer)
> > + #define DWARF_LINE_SIZE(p)   (PST_PRIVATE(p)->dwarf_line_size)
> >   #define DWARF_STR_BUFFER(p)  (PST_PRIVATE(p)->dwarf_str_buffer)
> >   #define DWARF_STR_SIZE(p)    (PST_PRIVATE(p)->dwarf_str_size)
> >   #define DWARF_MACINFO_BUFFER(p) (PST_PRIVATE(p)->dwarf_macinfo_buffer)
> 
> I'm wondering if we even need these macros.

It's true --- they're only used in contexts where one could just as
easily put PST_PRIVATE (p) in a variable and access the fields
directly.  I'd welcome a patch, if you wanted.