Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir.prus@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] GDB/MI: inferior standard I/O redirection
Date: Thu, 22 Oct 2015 10:55:00 -0000	[thread overview]
Message-ID: <n0a2pm$v59$1@ger.gmane.org> (raw)
In-Reply-To: <1444045617-14526-5-git-send-email-crosa@redhat.com>


Cleber, thanks for the patch! And thanks Pedro for the CC.

On 05-Oct-15 2:46 PM, Cleber Rosa wrote:
 > This introduces the following MI commands:
 >
 >   * -inferior-stdin-set
 >   * -inferior-stdin-show
 >   * -inferior-stdout-set
 >   * -inferior-stdout-show
 >   * -inferior-stderr-set
 >   * -inferior-stderr-show
 >
 > Which are the MI version of the inferior standard I/O redirection
 > commands:
 >
 >   * set inferior-stdin (aliased as stdin)
 >   * show inferior-stdin
 >   * set inferior-stdout (aliased as stdout)
 >   * show inferior-stdout
 >   * set inferior-stderr (aliased as stderr)

These additions look non-controversial to me.


 > +@subheading The @code{-inferior-stdin-set} Command
 > +@findex -inferior-stdin-set
 > +
 > +@subheading Synopsis
 > +
 > +@smallexample
 > +-inferior-stdin-set /tmp/answers
 > +@end smallexample
 > +
 > +Set standard input for future runs of the program being debugged.

This documentation does not specify what the parameter to the command is. Is this something you can write
explicitly, so that one does not have to consult CLI docs? It seems you need a filepath, in which case
writing

+@smallexample
+-inferior-stdin-set <filepath>
+@end smallexample

might be clearer (I don't remember texinfo syntax for replaceable part).

Do we want to support passing integer file descriptor here as well?

Thanks,
Volodya

-- 
Vladimir Prus
http://vladimirprus.com


      parent reply	other threads:[~2015-10-22  7:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 11:47 [PATCH 0/4]: GDB: " Cleber Rosa
2015-10-05 11:47 ` [PATCH 3/4] GDB/MI: add test for command -inferior-tty-show Cleber Rosa
2015-10-21 11:19   ` Pedro Alves
2015-10-05 11:47 ` [PATCH 1/4] GDB: inferior standard I/O redirection Cleber Rosa
2015-10-05 12:23   ` Eli Zaretskii
2015-10-21 11:18   ` Pedro Alves
2015-10-05 11:47 ` [PATCH 2/4] GDB/MI: fix and simplify mi_valid_noargs utility function Cleber Rosa
2015-10-21 11:19   ` Pedro Alves
2015-10-05 11:54 ` [PATCH 4/4] GDB/MI: inferior standard I/O redirection Cleber Rosa
2015-10-05 12:26   ` Eli Zaretskii
2015-10-21 11:19   ` Pedro Alves
2015-10-22 10:55   ` Vladimir Prus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='n0a2pm$v59$1@ger.gmane.org' \
    --to=vladimir.prus@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox