From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-161954-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 59813 invoked by alias); 9 Dec 2019 21:43:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 59805 invoked by uid 89); 9 Dec 2019 21:43:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail.bob131.so
Received: from server2.bob131.so (HELO mail.bob131.so) (128.199.153.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2019 21:43:17 +0000
Received: from internal.mail.bob131.so (localhost [127.0.0.1])	by mail.bob131.so (Postfix) with ESMTP id 228D652C27;	Mon,  9 Dec 2019 21:43:15 +0000 (UTC)
DKIM-Filter: OpenDKIM Filter v2.11.0 mail.bob131.so 228D652C27
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bob131.so;	s=default; t=1575927795;	bh=3RR/4dGB3MBl3CebnRw8+dyQFHDwYz4izGRoLCVhH0c=;	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;	b=m2tMKmmNv+/r2xJsDOsd+jJRiFWJZWyUKEBubUqfLOemub1au5Bb4lC7ZrMsv9ogG	 OekqFlhCW0vEXSPmcvzCQ3ae+iC8qLgZQOcgUGE2yqB2hMEa6ljw5KCFOzrqlyq9vw	 FJ+o0FlYmFJ1LX2+NZCqq5+FePG6kGoh5HymoTmLPYOeBPMIPrFu8YQe1A8rz8BN2K	 gnn1UCoXl6HVxTdZGF0BdwnpprVeTQH3NTY9iEQZcf2AtYVf1bEJThbGrT0Fp6uEwW	 5bhlit9qz7J32JYl3l+xWoBR/3kEGBap3vCqUgBC08SbCQyKsFdc+q5+nMmfRcPssl	 tH74YxED4GSmw==
Date: Mon, 09 Dec 2019 21:43:00 -0000
From: George Barrett <bob@bob131.so>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix scripted probe breakpoints
Message-ID: <mvtikg5f9d7hqbm-cro5b2ygqg-b9e44xho-k1cdn0.k49xmwvti@mail.bob131.so>
References: <gnmd5kmbvxo1_fu&9qbl8vh7shke4a&_pmietcvge3.1031yx5uw@mail.bob131.so> <a2980e3e-1d58-3fe3-8dd3-62b6c642cde1@simark.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a2980e3e-1d58-3fe3-8dd3-62b6c642cde1@simark.ca>
X-SW-Source: 2019-12/txt/msg00362.txt.bz2

On Mon, Dec 09, 2019 at 04:37:47PM -0500, Simon Marchi wrote:
> so would you like me to push the patch on your behalf?

Yes, please.

> I found some other really small nits, I'll fix them before pushing if I end
> up pushing for you.

> I missed this last time, but also in GNU style we compare pointers and
> integers explicitly, so either one of these would be good:

> I would change null to NULL or nullptr to match the language nomenclature.

> non-zero -> true

I appreciate the tips, sorry for the additional round-trips.

Thank you for your patience and speedy review!