From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47367 invoked by alias); 9 Jun 2015 12:43:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47356 invoked by uid 89); 9 Jun 2015 12:43:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 09 Jun 2015 12:43:26 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E8EC9ADB8; Tue, 9 Jun 2015 12:43:22 +0000 (UTC) From: Andreas Schwab To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [OB PATCH] Don't assume File-I/O mode bits match the host's format References: <1433853129-9470-1-git-send-email-gbenson@redhat.com> X-Yow: Jesus is my POSTMASTER GENERAL.. Date: Tue, 09 Jun 2015 12:43:00 -0000 In-Reply-To: <1433853129-9470-1-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Tue, 9 Jun 2015 13:32:09 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-06/txt/msg00125.txt.bz2 Gary Benson writes: > + if (fileio_mode & ~FILEIO_S_SUPPORTED) > + return -1; > + if (fileio_mode & FILEIO_S_IFCHR) > + mode |= S_IFCHR; FILEIO_S_SUPPORTED doesn't include FILEIO_S_IFCHR, so this is never true. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."