From: Andreas Schwab <schwab@suse.de>
To: Andrew Pinski <apinski@cavium.com>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH 3/3] Handle ILP32 AARCH64 correctly for gdbserver
Date: Thu, 01 Sep 2016 08:32:00 -0000 [thread overview]
Message-ID: <mvmoa48ggvt.fsf@hawking.suse.de> (raw)
In-Reply-To: <1472715400-43043-4-git-send-email-apinski@cavium.com> (Andrew Pinski's message of "Thu, 1 Sep 2016 00:36:40 -0700")
On Sep 01 2016, Andrew Pinski <apinski@cavium.com> wrote:
> diff --git a/gdb/gdbserver/linux-aarch64-ipa.c b/gdb/gdbserver/linux-aarch64-ipa.c
> index 601d61c..d713bfa 100644
> --- a/gdb/gdbserver/linux-aarch64-ipa.c
> +++ b/gdb/gdbserver/linux-aarch64-ipa.c
> @@ -29,6 +29,9 @@
> /* Defined in auto-generated file aarch64.c. */
> void init_registers_aarch64 (void);
> extern const struct target_desc *tdesc_aarch64;
> +/* Defined in auto-geenrated file aarch64_ilp32.c. */
generated
> @@ -155,6 +158,9 @@ get_raw_reg (const unsigned char *raw_regs, int regnum)
> const struct target_desc *
> get_ipa_tdesc (int idx)
> {
> + if (sizeof (void*) == 4)
Space before *.
> @@ -207,5 +213,8 @@ alloc_jump_pad_buffer (size_t size)
> void
> initialize_low_tracepoint (void)
> {
> - init_registers_aarch64 ();
> + if (sizeof(void*) == 4)
Space before ( and *.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
prev parent reply other threads:[~2016-09-01 8:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 0:26 [PATCH 0/3] Support AARCH64 ILP32 for gdb Andrew Pinski
2016-08-30 0:26 ` [PATCH 3/3] Handle ILP32 AARCH64 correctly for gdbserver Andrew Pinski
2016-08-30 8:01 ` Andreas Schwab
2016-08-31 10:42 ` Pedro Alves
2016-08-31 12:58 ` Yao Qi
2016-08-31 20:02 ` Andrew Pinski
2016-08-30 0:26 ` [PATCH 1/3] Move AARCH64 ILP32 rejection handling Andrew Pinski
2016-08-30 0:26 ` [PATCH 2/3] Add ILP32 support to gdb Andrew Pinski
2016-08-30 7:44 ` Andreas Schwab
2016-09-01 4:21 ` Andrew Pinski
2016-09-01 7:41 ` Andreas Schwab
2016-09-01 7:37 ` [PATCH v2 0/3] Support AARCH64 ILP32 for gdb Andrew Pinski
2016-09-01 7:36 ` [PATCH 2/3] Add ILP32 support to gdb Andrew Pinski
2016-09-01 9:50 ` Andreas Schwab
2016-09-01 13:13 ` Yao Qi
2016-09-01 7:37 ` [PATCH 1/3] Move AARCH64 ILP32 rejection handling Andrew Pinski
2016-09-01 9:43 ` Richard Earnshaw (lists)
2016-09-01 7:37 ` [PATCH 3/3] Handle ILP32 AARCH64 correctly for gdbserver Andrew Pinski
2016-09-01 8:32 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmoa48ggvt.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=apinski@cavium.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox