From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111626 invoked by alias); 26 Sep 2018 13:12:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111617 invoked by uid 89); 26 Sep 2018 13:12:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 13:12:09 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C72D0B13B; Wed, 26 Sep 2018 13:12:06 +0000 (UTC) From: Andreas Schwab To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Do not accidentally include in-tree readline headers References: <20180926125834.8845-1-tom@tromey.com> X-Yow: My mind is a potato field... Date: Wed, 26 Sep 2018 13:12:00 -0000 In-Reply-To: <20180926125834.8845-1-tom@tromey.com> (Tom Tromey's message of "Wed, 26 Sep 2018 06:58:34 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00845.txt.bz2 On Sep 26 2018, Tom Tromey wrote: > This patch fixes the problem in a mildly hacky way: remove the > offending -I option, and change gdb to use #include "../opcodes/..." > instead. This continues to make it clear where the header comes from, > without allowing incorrect behavior. Most of these headers are "opcode/...", not "opcodes/...". Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."