From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4145 invoked by alias); 22 Sep 2014 13:06:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4121 invoked by uid 89); 22 Sep 2014 13:06:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 3 recipients X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 22 Sep 2014 13:06:53 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8C2E6AAF1; Mon, 22 Sep 2014 13:06:50 +0000 (UTC) From: Andreas Schwab To: Joel Brobecker Cc: Chen Gang , bug-readline@gnu.org, amodra@gmail.com, Pedro Alves , jan.kratochvil@redhat.com, drow@false.org, ezannoni@kwikemart.cygnus.com, muller@sourceware.org, Nicholas Clifton , gdb-patches@sourceware.org, binutils@sourceware.org, macro@linux-mips.org Subject: Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message() References: <541CF976.8090905@gmail.com> <20140922130324.GA4883@adacore.com> X-Yow: Don't worry, nobody really LISTENS to lectures in MOSCOW, either! .. FRENCH, HISTORY, ADVANCED CALCULUS, COMPUTER PROGRAMMING, BLACK STUDIES, SOCIOBIOLOGY!.. Are there any QUESTIONS?? Date: Mon, 22 Sep 2014 13:06:00 -0000 In-Reply-To: <20140922130324.GA4883@adacore.com> (Joel Brobecker's message of "Mon, 22 Sep 2014 09:03:24 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-09/txt/msg00660.txt.bz2 Joel Brobecker writes: > Hi Chen, > >> The related warning under Darwin x86_64: >> >> gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c >> ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args] >> rl_message ("%s", p, 0); >> ~~~~ ^ >> 1 warning generated. >> >> >> readline/ChangeLog.gdb: >> >> * search.c (_rl_nsearch_init): Remove useless parameter '0' for >> rl_message(). > > Because readline is a separate project from binutils/GDB, we prefer > it if you would first submit the patch to the readline project first > (bug-readline@gnu.org, in Cc: of this email), get it accepted there. This bug was already fixed in bash 4.3. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."