From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-133099-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 112037 invoked by alias); 30 Aug 2016 07:44:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 111178 invoked by uid 89); 30 Aug 2016 07:44:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Aug 2016 07:44:08 +0000
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 2C57AAAC7;	Tue, 30 Aug 2016 07:44:06 +0000 (UTC)
From: Andreas Schwab <schwab@suse.de>
To: Andrew Pinski <apinski@cavium.com>
Cc: gdb-patches@sourceware.org,  binutils@sourceware.org
Subject: Re: [PATCH 2/3] Add ILP32 support to gdb.
References: <1472516750-30743-1-git-send-email-apinski@cavium.com>	<1472516750-30743-3-git-send-email-apinski@cavium.com>
X-Yow: If I have enough money to buy 5,000 CANS of NOODLE-RONI, can I get a VAT of MARSHMALLOW FLUFF free??
Date: Tue, 30 Aug 2016 07:44:00 -0000
In-Reply-To: <1472516750-30743-3-git-send-email-apinski@cavium.com> (Andrew	Pinski's message of "Mon, 29 Aug 2016 17:25:49 -0700")
Message-ID: <mvminuiln0a.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2016-08/txt/msg00297.txt.bz2

On Aug 30 2016, Andrew Pinski <apinski@cavium.com> wrote:

> @@ -2695,6 +2696,11 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>        return NULL;
>      }
>  
> +  if (info.abfd
> +      && bfd_get_flavour (info.abfd) == bfd_target_elf_flavour
> +      && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS32)
> +    ilp32 = TRUE;
> +

Shouldn't this use bfd_arch_bits_per_address?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."