From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101435 invoked by alias); 19 May 2016 13:32:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101421 invoked by uid 89); 19 May 2016 13:32:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 19 May 2016 13:32:34 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DC1EBAB1A; Thu, 19 May 2016 13:32:30 +0000 (UTC) From: Andreas Schwab To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix invalid implicit conversions from void * References: <27288423-ea78-4bd7-6eb2-68911a275690@redhat.com> X-Yow: They collapsed.... like nuns in the street... they had no teen appeal! Date: Thu, 19 May 2016 13:32:00 -0000 In-Reply-To: <27288423-ea78-4bd7-6eb2-68911a275690@redhat.com> (Pedro Alves's message of "Thu, 19 May 2016 14:07:48 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-05/txt/msg00325.txt.bz2 Pedro Alves writes: > On 05/19/2016 01:54 PM, Andreas Schwab wrote: >> Tested on ia64-suse-linux. > > Thanks. > >> >> * ia64-libunwind-tdep.c (libunwind_descr): Add cast from void *. >> (libunwind_frame_set_descr): Likewise. >> (libunwind_frame_cache): Likewise. >> (libunwind_frame_dealloc_cache): Likewise. >> (libunwind_frame_sniffer): Likewise. >> (libunwind_search_unwind_table): Likewise. >> (libunwind_sigtramp_frame_sniffer): Likewise. >> (libunwind_get_reg_special): Likewise. >> (libunwind_load): Likewise. >> * ia64-linux-nat.c (ia64_linux_fetch_register): Likewise. >> (ia64_linux_store_register): Likewise. >> (ia64_linux_xfer_partial): Likewise. >> * ia64-tdep.c (ia64_access_reg): Likewise. >> (ia64_access_fpreg): Likewise. >> (ia64_access_rse_reg): Likewise. >> (ia64_access_rse_fpreg): Likewise. > > This is OK. Though ... > >> /* Initialize pointers to the dynamic library functions we will use. */ >> >> - unw_get_reg_p = dlsym (handle, get_reg_name); >> + unw_get_reg_p = ((int (*) (unw_cursor_t *, unw_regnum_t, unw_word_t *)) >> + dlsym (handle, get_reg_name)); > > ... I think would be nicer to use typedefs for these. Installed with that change. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."