From: Andreas Schwab <schwab@suse.de>
To: Gary Benson <gbenson@redhat.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
gdb-patches@sourceware.org,
"'Andrew Burgess'" <aburgess@broadcom.com>,
"'Doug Evans'" <xdje42@gmail.com>,
"'Eli Zaretskii'" <eliz@gnu.org>,
"'Florian Weimer'" <fw@deneb.enyo.de>,
"'Mark Kettenis'" <mark.kettenis@xs4all.nl>,
"'Pedro Alves'" <palves@redhat.com>,
"'Tom Tromey'" <tromey@redhat.com>,
"'Corinna Vinschen'" <vinschen@redhat.com>
Subject: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler
Date: Mon, 14 Jul 2014 10:28:00 -0000 [thread overview]
Message-ID: <mvm8unwpbgi.fsf@hawking.suse.de> (raw)
In-Reply-To: <20140714085154.GA27730@blade.nx> (Gary Benson's message of "Mon, 14 Jul 2014 09:51:54 +0100")
Gary Benson <gbenson@redhat.com> writes:
> diff --git a/gdb/cp-support.c b/gdb/cp-support.c
> index a8ea6fc..6a09b46 100644
> --- a/gdb/cp-support.c
> +++ b/gdb/cp-support.c
> @@ -1557,7 +1557,9 @@ gdb_demangle (const char *name, int options)
> #if defined (HAVE_SIGACTION) && defined (SA_RESTART)
> sa.sa_handler = gdb_demangle_signal_handler;
> sigemptyset (&sa.sa_mask);
> +#ifdef HAVE_SIGALTSTACK
> sa.sa_flags = SA_ONSTACK;
> +#endif
You probably need to initialize sa.sa_flags in any case.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2014-07-14 8:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:22 [PATCH 0/3 " Gary Benson
2014-06-09 15:23 ` [PATCH 1/3 v5] Add new internal problem for demangler warnings Gary Benson
2014-06-09 16:19 ` Eli Zaretskii
2014-06-09 15:24 ` [PATCH 3/3 v5] Demangler crash handler Gary Benson
2014-06-09 16:20 ` Eli Zaretskii
2014-06-09 18:25 ` Gary Benson
2014-07-14 0:31 ` Cygwin build failure following " Pierre Muller
2014-07-14 8:52 ` Corinna Vinschen
2014-07-14 12:10 ` Gary Benson
2014-07-14 8:54 ` Gary Benson
2014-07-14 10:28 ` Andreas Schwab [this message]
[not found] ` <20140714114241.GA31867@blade.nx>
2014-07-14 16:13 ` Tom Tromey
2014-07-14 17:52 ` Pierre Muller
2014-06-09 15:24 ` [PATCH 2/3 v5] Refactor and expose core-dumping functionality Gary Benson
2014-06-11 20:41 ` [PATCH 0/3 v5] Demangler crash handler Tom Tromey
2014-06-11 21:03 ` Mark Kettenis
2014-06-19 8:23 ` [COMMITTED PATCH " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm8unwpbgi.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=aburgess@broadcom.com \
--cc=eliz@gnu.org \
--cc=fw@deneb.enyo.de \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=tromey@redhat.com \
--cc=vinschen@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox