From: Vladimir Prus <vladimir.prus@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: [WIP] Bare-metal register browsing
Date: Wed, 03 Jun 2015 19:49:00 -0000 [thread overview]
Message-ID: <mknln8$kj9$1@ger.gmane.org> (raw)
In-Reply-To: <86lhg2nu3x.fsf@gmail.com>
On 6/2/2015 4:00 PM, Yao Qi wrote:
> Vladimir Prus <vladimir.prus@gmail.com> writes:
>
>> <space annex="memory" name="io">
>> <group name="UART2">
>> <reg bitsize="32" name="UART2CTL" offset="0x4000e030" read-sensitive="no" save-restore="yes" type="UART0_UART0CTL"/>
>> <reg bitsize="32" name="UART2LTIM" offset="0x4000e098" read-sensitive="no" save-restore="yes" type="UART0_UART0LTIM"/>
>> </group>
>> <group name="UART3">
>> size="32" name="UART3CTL" offset="0x4000f030" read-sensitive="no" save-restore="yes" type="UART0_UART0CTL"/>
>> <reg bitsize="32" name="UART3LTIM" offset="0x4000f098" read-sensitive="no" save-restore="yes" type="UART0_UART0LTIM"/>
>> </group>
>
> It is good to have a "group" element, so that we can easily define a
> group of registers. However, what is the usefulness of element "space"?
> to define a group of "group" elements?
The original motivation was to indicate that particular set of registers are not usual registers, and must
be accessed in a different way. It's not strictly necessary, we can rewrite the above as:
<group name="io" target-object="spaces" annex="memory">
<group name="UART2">
<reg offset="0x4000e030" .../>
</group>
</group>
Maybe my patch can be modified to not introduce a new target object, after all. We can use:
<group name="io" target-object="memory">
<group name="UART2">
<reg offset="0x4000e030" .../>
</group>
</group>
to describe memory-mapped io registers.
It sounds like this should be possible to implement. What do you think?
Two questions:
- Is 'group' ok, or 'register-group' would be more clear? We found that the size of these XML
files can be sometimes a problem
- I'd propose that 'target-object' and 'annex' attribute are only allowed for top-level 'group' element,
and not for top-level 'reg' or nested 'group' element, to make implementation simpler. Is that fine?
Thanks,
Volodya
next prev parent reply other threads:[~2015-06-03 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 6:30 Vladimir Prus
2015-04-24 9:47 ` Yao Qi
2015-04-27 18:25 ` Vladimir Prus
2015-04-27 18:39 ` Vladimir Prus
2015-06-01 18:36 ` Vladimir Prus
2015-06-02 13:00 ` Yao Qi
2015-06-03 19:49 ` Vladimir Prus [this message]
2015-06-04 14:38 ` Yao Qi
2015-06-09 20:50 ` Vladimir Prus
2015-06-11 8:56 ` Yao Qi
2015-06-15 13:51 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='mknln8$kj9$1@ger.gmane.org' \
--to=vladimir.prus@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox