From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58015 invoked by alias); 24 Apr 2017 16:12:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57977 invoked by uid 89); 24 Apr 2017 16:12:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=palmer, Palmer, metal X-HELO: mail-pg0-f41.google.com Received: from mail-pg0-f41.google.com (HELO mail-pg0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Apr 2017 16:12:19 +0000 Received: by mail-pg0-f41.google.com with SMTP id 63so15330137pgh.0 for ; Mon, 24 Apr 2017 09:12:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :mime-version; bh=3cUII8tHb5T9CokoxjRo/t62dowpBbKRMwgtikqr0hQ=; b=H/YFJIkZelosDwq0iulPaj6nDZj/8b08y/M3TPNgK9RfP2DSY6h8FzBpN6NGhfjw4p airRMH+iAAce4/YXXK1ox6zsS1DjUVjpEDgsCEtegfZgvF/8oHijPqyCRTg7N37qQDoc SqRtOQXvWbOLjD2T022t7twpCN/86Ov7M90/24spdN45dQm0KMvaUTQtOgCyVKaYj7jt t0iEUGtxaCVBroYXT0080JzhORAOKqlqynIy4TIuxaV0APdFYfRFC6NL5XUZ1+9O8p0b CuUXnMaGJF+eeWKK/koPiz9XU+qeYp8IOqL4vlhbpz/FQ3myfnJ4IasStvsrmrFC4bo1 TMog== X-Gm-Message-State: AN3rC/6XZ7AXgETW4Xxd7DQBnl/zBACQAlNzGv6YPMbQwoBL1zPDk9jQ kqpmTIb5+eJdMQ== X-Received: by 10.99.126.23 with SMTP id z23mr20925463pgc.63.1493050340332; Mon, 24 Apr 2017 09:12:20 -0700 (PDT) Received: from localhost ([216.38.154.21]) by smtp.gmail.com with ESMTPSA id k196sm31847018pgc.0.2017.04.24.09.12.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Apr 2017 09:12:19 -0700 (PDT) Date: Mon, 24 Apr 2017 16:12:00 -0000 X-Google-Original-Date: Mon, 24 Apr 2017 09:05:18 PDT (-0700) From: Palmer Dabbelt To: qiyaoltc@gmail.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] RISC-V GDB Port In-Reply-To: <86a87v6dzr.fsf@gmail.com> Message-ID: Mime-Version: 1.0 (MHng) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00651.txt.bz2 On Tue, 04 Apr 2017 14:48:24 PDT (-0700), qiyaoltc@gmail.com wrote: > Palmer Dabbelt writes: > > Hi, > I have some time today, so I can review the patch. > >> gdb/Makefile.in | 5 + >> gdb/config/riscv/linux.mh | 30 + >> gdb/features/Makefile | 2 + >> gdb/features/riscv.c | 86 +++ >> gdb/features/riscv.xml | 81 +++ >> gdb/gdbserver/linux-riscv-low.c | 221 +++++++ >> gdb/regformats/riscv.dat | 69 ++ >> gdb/riscv-linux-nat.c | 77 +++ >> gdb/riscv-linux-tdep.c | 80 +++ >> gdb/riscv-linux-tdep.h | 30 + >> gdb/riscv-tdep.c | 1368 +++++++++++++++++++++++++++++++++++++++ >> gdb/riscv-tdep.h | 96 +++ >> include/gdb/sim-riscv.h | 98 +++ > > Before I read the patch further, my suggestion is to split your patch > to following parts next time, > > - bare metal support, riscv-tdep.c > - linux target support, riscv-linux-tdep.c, > - linux host support, riscv-linux-nat.c, > - gdbserver support, gdbserver/linux-riscv-low.c > - target description, Thanks for all the time you've spent on this, I'll try to get the port in better shape. > I am surprised that there is no change to gdb/testsuite/. We've generally not tested things well, I'll have some tests for the next round.