From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93323 invoked by alias); 10 Mar 2017 19:38:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93223 invoked by uid 89); 10 Mar 2017 19:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Port, XML, fell, our X-HELO: mail-pf0-f182.google.com Received: from mail-pf0-f182.google.com (HELO mail-pf0-f182.google.com) (209.85.192.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Mar 2017 19:38:47 +0000 Received: by mail-pf0-f182.google.com with SMTP id v190so45349152pfb.1 for ; Fri, 10 Mar 2017 11:38:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:in-reply-to:message-id :mime-version; bh=fXEs/c3DX4yMKIbZMISA8CcdDQ/mz7wbMNdkFcHUzi4=; b=OxMgUQ6ZfL3tMeYN1J8XXXZzJRx4e9FXTaJY/7KyciZaY8XRIBbKuFQ2+LnKmlml8A xgtn1F8862kLln477ApbQ5l6//XDfrZsqL3a4cWYXsYZ2Cckqd3yN+c5EE06jJGOGp3a CBKlkTCXN4cA3DbjskNiTY5XqTto4oO9uHcL4KswcT5F3+x4ikRzj8lcsolWJKhqelDw f/cETVzesauXyDQaJg9J/VrF7Rytii41H4zlMsVpN8m4wrLnbRw/WwzUjKcueqmeyV7M YImzjxpuZO9kWFMwAa/N8XD+VQQZtMYDOBlT5hefStiwEKcJ05Gj+GDD98HAPk0dINE8 q5PQ== X-Gm-Message-State: AMke39m38pbzGUsqCbmbxe4yizlTD76Jz3mLltK14kxZqlvoN1V7JZk58UVOvLPiXznXCw== X-Received: by 10.84.176.131 with SMTP id v3mr27719147plb.7.1489174726548; Fri, 10 Mar 2017 11:38:46 -0800 (PST) Received: from localhost ([216.38.154.21]) by smtp.gmail.com with ESMTPSA id s21sm20116493pfs.87.2017.03.10.11.38.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 11:38:46 -0800 (PST) Date: Fri, 10 Mar 2017 19:38:00 -0000 X-Google-Original-Date: Fri, 10 Mar 2017 11:38:42 PST (-0800) From: Palmer Dabbelt To: gdb-patches@sourceware.org Subject: Re: RISC-V GDB Port v3 In-Reply-To: <20170307043029.3672-1-palmer@dabbelt.com> Message-ID: Mime-Version: 1.0 (MHng) X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00150.txt.bz2 On Mon, 06 Mar 2017 20:30:27 PST (-0800), Palmer Dabbelt wrote: > Sorry it took me so long to get around to all the feedback, I was trying to > finish up grad school so I could start working full time on RISC-V software and > the GDB port fell through the cracks. This is now part of my job, so hopefully > I'll be able to be better about this in the future. > > I've attempted to fix all the outstanding comments with the v2 patch set, but > since it's been a while I'm not 100% sure I got everything. Here's the > differences I remember since v2: > > * Changes the frame walking code to use riscv-opc.h instead of hard-coded > constants. > > * Don't call deprecated functions when printing FP registers. > > * Use the sw_breakpoint_from_kind interface. > > * Add a RISC-V XML target description file, but I think it doesn't do anything > yet. > > I think the only thing I know of that's bad is the target XML description file, > which I don't think works yet. That said, I want to send this patch set out > just so we can all get on the same page. > > If I understand correctly, GDB-8 is set to be branched on the 15th so if I can > fix up our port quickly we can still get it in? > > Sorry this took so long! > > [PATCH 1/2] RISC-V GDB Port > [PATCH 2/2] RISC-V sim Port I just wanted to ping this patch set because I haven't gotten any comment all week. Does anyone have any reviews, or do the patches look OK this time around?