From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30187 invoked by alias); 17 Apr 2015 15:18:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30178 invoked by uid 89); 17 Apr 2015 15:18:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_00,FSL_HELO_BARE_IP_2,RCVD_IN_DNSWL_LOW,RCVD_NUMERIC_HELO,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 17 Apr 2015 15:18:34 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Yj82I-0000cB-QF for gdb-patches@sourceware.org; Fri, 17 Apr 2015 17:18:30 +0200 Received: from 194.186.53.35 ([194.186.53.35]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Apr 2015 17:18:30 +0200 Received: from vladimir by 194.186.53.35 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 17 Apr 2015 17:18:30 +0200 To: gdb-patches@sourceware.org From: Vladimir Prus Subject: Re: [PATCH 2/2] Testsuite for varobj updation after symbol removal Date: Fri, 17 Apr 2015 15:18:00 -0000 Message-ID: References: <1429155160-4816-1-git-send-email-tmirza@codesourcery.com> <1429155160-4816-3-git-send-email-tmirza@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 In-Reply-To: <1429155160-4816-3-git-send-email-tmirza@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00683.txt.bz2 On 04/16/2015 06:32 AM, Taimoor Mirza wrote: > This patch provides testcases for variable object updation after removing > symbols. Test programs are same as used for testing remove-symbol-file > command in gdb.base. sym-file-main.c is modified to just add a global > variable for which varible object is created in testsuite. > Taimoor, thanks for the patch, and testsuite change. Looking at it, it appears that 'count' is a global variable, and it's modified in one place, in the main function, and after that you do 'remove-symbol-files' and verify that var-update reports reports 'count' as changed. But what does it test exactly? Since count is explicitly modified in the test, I'd imagine that -var-update will report it as changed even without 'remove-symbol-file'. In other words, does this testcase fail if the code patch is not applied? Even if so, does it test exactly what is your real case? It's easy to see why 'remove-symbol-files' can make some global variables no longer present. But how it can change value of some expression? Thanks, Volodya -- Vladimir Prus CodeSourcery / Mentor Embedded http://vladimirprus.com