From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31010 invoked by alias); 7 Jun 2010 14:04:16 -0000 Received: (qmail 30870 invoked by uid 22791); 7 Jun 2010 14:04:15 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jun 2010 14:04:06 +0000 Received: from hpaq3.eem.corp.google.com (hpaq3.eem.corp.google.com [172.25.149.3]) by smtp-out.google.com with ESMTP id o57E4417028363; Mon, 7 Jun 2010 07:04:04 -0700 Received: from pzk7 (pzk7.prod.google.com [10.243.19.135]) by hpaq3.eem.corp.google.com with ESMTP id o57E42uQ030780; Mon, 7 Jun 2010 07:04:02 -0700 Received: by pzk7 with SMTP id 7so1877338pzk.30 for ; Mon, 07 Jun 2010 07:04:01 -0700 (PDT) Received: by 10.141.124.10 with SMTP id b10mr11686306rvn.176.1275919437914; Mon, 07 Jun 2010 07:03:57 -0700 (PDT) Received: from coign.google.com ([67.218.103.83]) by mx.google.com with ESMTPS id o38sm842884rvp.14.2010.06.07.07.03.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 07 Jun 2010 07:03:56 -0700 (PDT) To: Ralf Wildenhues Cc: Paolo Bonzini , binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR bootstrap/42798 References: <20100601204405.GA1170@gmx.de> <20100602111845.GA16161@ins.uni-bonn.de> <4C064B77.3020207@gnu.org> <20100603063319.GC28276@gmx.de> <20100603065852.GA28617@gmx.de> <20100606112828.GC29478@gmx.de> <20100607061142.GA29811@gmx.de> From: Ian Lance Taylor Date: Mon, 07 Jun 2010 14:04:00 -0000 In-Reply-To: <20100607061142.GA29811@gmx.de> (Ralf Wildenhues's message of "Mon\, 7 Jun 2010 08\:11\:45 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00173.txt.bz2 Ralf Wildenhues writes: > * Ian Lance Taylor wrote on Sun, Jun 06, 2010 at 11:42:13PM CEST: > >> My question about a basename declaration in the system header was a >> genuine question. My concern is that on some systems this patch might >> decide incorrectly whether or not basename is defined, which could >> then possibly lead to a compilation error when libiberty.h is >> included. > > This concern should be addressed with my reply > : > In short, the Autoconf change is designed to handle exactly this case > right both in C and in C++ mode. That doesn't really address my concern. That shows that autoconf will get a workable answer if I use only C++. But there is only one config.h file. gold has both .c and .cc files (the .c files are used via AC_REPLACE_FUNCS). It's not obvious to me that a version of HAVE_DECL_BASENAME for C++ will necessarily work when compiling C. Ian