Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA]: Handle multi-line versions of multi-breakpoints
Date: Thu, 23 Apr 2009 22:47:00 -0000	[thread overview]
Message-ID: <m3zle7oum1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090302065301.356261C7A1E@localhost> (Doug Evans's message of "Sun\,  1 Mar 2009 22\:53\:01 -0800 \(PST\)")

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> "multi-breakpoints" (multiple breakpoints for the same source
Doug> line) don't work for constructors and inline functions where the
Doug> source expression spans several lines (at least for the new
Doug> testcases included in this patch).

Doug> This patch fixes it by, if there's no exact match,
Doug> rescanning the symtabs for all matches of the best match.

This sounds like Jerome's patch, which I approved earlier today.  I
didn't realize that you had both fixed the same problem before doing
that.

After reading both patches, I would prefer for his to go in; assuming
of course that it actually does fix your problem as well.

Your test cases seem more comprehensive.  I would not mind seeing
these go in after his patch.  They are ok, if you want to do that.

Tom


      parent reply	other threads:[~2009-04-23 22:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-02  6:53 Doug Evans
2009-03-13 17:04 ` Doug Evans
2009-03-29  4:32   ` Doug Evans
2009-04-23 21:27     ` Doug Evans
2009-04-23 22:47 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zle7oum1.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox