Re: [RFC] Let "gcore" command accept a suffix argument

Eli Zaretskii
2010-06-22T18:05:45Z

> From: Hui Zhu <teawater@gmail.com>
> Date: Tue, 22 Jun 2010 15:29:03 +0800
> Cc: Stan Shebs <stanshebs@earthlink.net>, Stan Shebs <stan@codesourcery.com>,
> Michael Snyder <msnyder@vmware.com>, gdb-patches ml <gdb-patches@sourceware.org>
>
> I make a new patch according to your mails.
>
> It include the code, doc and test. Please help me review it.

Thanks. The doc parts are okay, with these two comments:

> +eval template, expressions...
> + Convert the values of one or more expressions under the control
> + of the string template to a command line and call it.
^
A comma here, please.

> +@item eval @var{template}, @var{expressions}@dots{}
> +Convert the values of one or more @var{expressions} under the control of
> +the string @var{template} to a command line and call it.
^
Same here.