From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25945 invoked by alias); 23 Feb 2010 23:05:50 -0000 Received: (qmail 25919 invoked by uid 22791); 23 Feb 2010 23:05:49 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Feb 2010 23:05:45 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1NN5gV9001516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Feb 2010 18:05:42 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1NN5fKf029163; Tue, 23 Feb 2010 18:05:41 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1NN5eVr005584; Tue, 23 Feb 2010 18:05:41 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 3C20A3780ED; Tue, 23 Feb 2010 16:05:40 -0700 (MST) From: Tom Tromey To: Phil Muldoon Cc: Eli Zaretskii , gdb-patches ml Subject: Re: [patch][python] Add symbol, symbol table and frame block support to GDB API References: <4B66DA35.7080701@redhat.com> <4B796506.7010909@redhat.com> <20100219141457.GB2602@localhost.localdomain> Reply-To: tromey@redhat.com Date: Tue, 23 Feb 2010 23:05:00 -0000 In-Reply-To: <20100219141457.GB2602@localhost.localdomain> (Phil Muldoon's message of "Fri, 19 Feb 2010 14:14:57 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00577.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Tom> I think this could use a NEWS entry. I suggest waiting until my earlier Tom> patch is approved, then adding items to that block... assuming your Tom> patch goes in before 7.1. Otherwise, add a new Python block in the Tom> post-7.1 changes. Phil> I included one in the patch I sent. Here is the hunk: Thanks, I must have missed it. Sorry about that. Phil> This hunk puts it in the 7.1 release section. I'll move it when we Phil> figure out what release it will be in (as of today, looks like 7.2). Yeah, 7.2 now. Phil> I ended up just reusing the FRAPY_REQUIRE_VALID code that is in Phil> py-frame.c. That code is bogus too, but I didn't want to burden you with this, at least not for this patch ;). Phil> +static PyObject * Phil> +sympy_str (PyObject *self) [...] Phil> + s = xstrprintf ("symbol for %s", Phil> + SYMBOL_PRINT_NAME (symbol)); Tom> Why not just have this be SYMBOL_PRINT_NAME? Tom> I forgot the difference between the various python to-string methods. Tom> Maybe this one is supposed to be more verbose? Let me know. Phil> One of the tricky things I've found in merging work is I'm often not Phil> the original author of that work. Totally understood. This is all my fault or Thiago's :) Phil> And my understanding of Python's "print object" Phil> -> string is more for human consumption that for comparison or Phil> assingment. That being said, I've no strong feelings on it. I did not Phil> change it in this patch. If you want it changed, I'll happily do it. Yes, I think we should change it so that "print foo" or "str(foo)" yields the "most natural" name. In this case it is just the print name. Phil> + s = xstrprintf ("symbol table for %s", Phil> + symtab->filename); Tom> Also as above. Phil> I'm not sure what this means, is it referring to the sympy_str Phil> comment? Yeah, sorry, do like sympy_str. In this case I think it should just return the filename. Phil> + s = xstrprintf ("symbol and line for %s, line %d", filename, Phil> + sal->line); Tom> Phil> Ditto, sympy_str comment. I am not sure what is nicest to return here; it is probably fine to leave it as-is for the time being. thanks, Tom