From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5184 invoked by alias); 30 Mar 2010 16:11:03 -0000 Received: (qmail 5169 invoked by uid 22791); 30 Mar 2010 16:11:02 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 16:10:56 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGAqOx000346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Mar 2010 12:10:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGAqaL019490; Tue, 30 Mar 2010 12:10:52 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGApKb009098; Tue, 30 Mar 2010 12:10:51 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 51F25378185; Tue, 30 Mar 2010 10:10:51 -0600 (MDT) From: Tom Tromey To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: use socklen_t with accept() References: <1269891513-2771-1-git-send-email-vapier@gentoo.org> Reply-To: tromey@redhat.com Date: Tue, 30 Mar 2010 16:11:00 -0000 In-Reply-To: <1269891513-2771-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Mon, 29 Mar 2010 15:38:33 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01051.txt.bz2 >>>>> "Mike" == Mike Frysinger writes: Mike> The accept() function takes a socklen_t, not an int. I thought there were still platforms where accept took an int*. gnulib at least implies it: http://www.gnu.org/software/gnulib/manual/html_node/accept.html ... but doesn't mention which ones. Given that both gdb and gdbserver check for socklen_t and typedef it if it does not exist, I think sim ought to as well. Tom