From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71869-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14887 invoked by alias); 8 Apr 2010 19:57:04 -0000
Received: (qmail 14879 invoked by uid 22791); 8 Apr 2010 19:57:03 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Apr 2010 19:56:57 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o38JuXYN005284 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Thu, 8 Apr 2010 15:56:33 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o38JuW9u024610; 	Thu, 8 Apr 2010 15:56:32 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o38JuVrW011315; 	Thu, 8 Apr 2010 15:56:32 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 584E0378887; Thu,  8 Apr 2010 13:56:31 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,         gdb-patches ml <gdb-patches@sourceware.org>,         Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add breakpoint support.
References: <4BB0B063.6000600@redhat.com> <20100405162648.GD19194@adacore.com> 	<4BBB3AF6.8050407@redhat.com> <m3ochvt1fr.fsf@fleche.redhat.com> 	<4BBDCF0E.9020904@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Thu, 08 Apr 2010 19:57:00 -0000
In-Reply-To: <4BBDCF0E.9020904@redhat.com> (Phil Muldoon's message of "Thu, 08 	Apr 2010 13:41:50 +0100")
Message-ID: <m3zl1dpvkg.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00188.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I've replaced the BPPY_VALID_P macro with a static function in this
Phil> patch.  I also updated the s/ask/task typo.  What do you think?

Looks ok to me.
Thanks for doing this.

Tom