From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74118-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25743 invoked by alias); 1 Jul 2010 15:25:12 -0000
Received: (qmail 25733 invoked by uid 22791); 1 Jul 2010 15:25:12 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 15:25:07 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o61FOxUu026274	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 1 Jul 2010 11:25:00 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o61FOxsH015984;	Thu, 1 Jul 2010 11:24:59 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o61FOwbP027817;	Thu, 1 Jul 2010 11:24:58 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 245A75080A9; Thu,  1 Jul 2010 09:24:58 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Stan Shebs <stan@codesourcery.com>,        Jan Kratochvil <jkratoch@redhat.com>
Subject: Re: collecting optimized out variables regression (Re: RFA: rewrite dwarf->ax translator
References: <m3ljbgdc4a.fsf@fleche.redhat.com>	<m3r5kyl3zt.fsf@fleche.redhat.com>	<m3ocfrzxia.fsf_-_@fleche.redhat.com>	<201007011343.00392.pedro@codesourcery.com>
Reply-To: tromey@redhat.com
Date: Thu, 01 Jul 2010 15:25:00 -0000
In-Reply-To: <201007011343.00392.pedro@codesourcery.com> (Pedro Alves's	message of "Thu, 1 Jul 2010 13:42:59 +0100")
Message-ID: <m3zkybns1h.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00009.txt.bz2

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

>> -  if (!data || size == 0)
>> -    {
>> -      value->optimized_out = 1;
>> -      return;
>> -    }

Pedro> Apparently, this bit was lost with the rewrite.

Oops, sorry about that.

Pedro> This patch fixes it for me.  Is this the correct approach, or
Pedro> maybe there was intent to handle this differently?

It looks good to me.

Tom