Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [patch] .gdb_index: Fix Ada regression
Date: Tue, 14 Sep 2010 22:45:00 -0000	[thread overview]
Message-ID: <m3zkvk3tu7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100914205711.GA10361@host1.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Tue, 14 Sep 2010 22:57:11 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> During my tests with `set language ada' I could not lookup non-Ada symbols
Jan> anyway so I believe the patch is OK but sure it needs an Ada-wise review.

The comment explains it all.  Thanks.

Jan> 2010-09-14  Jan Kratochvil  <jan.kratochvil@redhat.com>

Jan> 	* dwarf2read.c (dw2_map_ada_symtabs): Remove the internal_error.
Jan> 	Update the comment.

This is ok.

Tom


  reply	other threads:[~2010-09-14 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14 21:40 Jan Kratochvil
2010-09-14 22:45 ` Tom Tromey [this message]
2010-09-15  3:29   ` Jan Kratochvil
2010-09-15  7:29     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zkvk3tu7.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox